From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH] drm/amd/powerplay: use ARRAY_SIZE() for size of array Date: Thu, 12 May 2016 10:49:36 +0100 Message-ID: <20160512094936.GO7910@imgtec.com> References: <1462988936-13486-1-git-send-email-falakreyaz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id 42EDB6E7EE for ; Thu, 12 May 2016 09:48:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1462988936-13486-1-git-send-email-falakreyaz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Muhammad Falak R Wani Cc: Nils =?utf-8?Q?Wallm=C3=A9nius?= , Jammy Zhou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Rex Zhu , Christian Knig , Dan Carpenter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMTEsIDIwMTYgYXQgMTE6MTg6NDNQTSArMDUzMCwgTXVoYW1tYWQgRmFsYWsg UiBXYW5pIHdyb3RlOgo+IFVzZSBBUlJBWV9TSVpFKCkgZm9yIHRoZSBzaXplIGNhbGN1bGF0aW9u IG9mIHRoZSBhcnJheS4gQWxzbyBtb3ZlIHRoZQo+IGNvbmRpdGlvbiBldmF1bGF0aW9uIGZ1bmN0 aW9uIG91dCBvZiB0aGUgZm9yIGxvb3AuCj4gQWx0aG91Z2gsIGFueSByZXNwZWN0YWJsZSBjLWNv bXBpbGVyIHdvdWxkIG9wdGltaXplIHRoaXMgYW5kIGV2YWx1YXRlCj4gdGhlIGZ1bmN0aW9uIG9u bHkgb25jZSBvdXRzaWRlIHRoZSBsb29wLCBidXQgdGhlIG9wdGltemF0aW9uIGVuZ2luZQo+IG9m IGdjYyBpcyBiaXQgYnJhaW4tZGVhZCwgYW5kIGF0IHRpbWVzIG5lZWRzIHNvbWUgaGFuZCBob2xk aW5nLgoKYHNpemVvZmAgaXMgYWN0dWFsbHkgYSBjb21waWxlLXRpbWUgdGhpbmcsIHNvIGF0IHdv cnN0LCBpZiBubwpvcHRpbWlzYXRpb24gaXMgbWFkZSwgdGhlIHJ1bnRpbWUgcmVzdWx0IGlzIGEg ZGl2aXNpb24gb2YgdHdvCmxpdGVyYWxzLCBlZy4gYGZvciAoaSA9IDA7IGkgPCA2NC84OyBpKysp YCAod2hpY2ggSSBkb3VidCBhbnkKY29tcGlsZXIgd291bGQgbGVhdmUgYXMgaXMgYW55d2F5KQoK U28sICsxIG9uIHVzaW5nIEFSUkFZX1NJWkUsIC0xIG9uIGNyZWF0aW5nIGEgbmV3IHZhcmlhYmxl ICh3aGljaAppcyBub3QgZXZlbiBgY29uc3RgIGJ0dykKCj4gCj4gU2lnbmVkLW9mZi1ieTogTXVo YW1tYWQgRmFsYWsgUiBXYW5pIDxmYWxha3JleWF6QGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvc211bWdyL2N6X3NtdW1nci5jIHwgMyArKy0KPiAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVtZ3IvY3pfc211bWdyLmMgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9zbXVtZ3IvY3pfc211bWdyLmMKPiBpbmRleCBk YTE4ZjQ0Li43MThhNTUxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJw bGF5L3NtdW1nci9jel9zbXVtZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvcG93ZXJw bGF5L3NtdW1nci9jel9zbXVtZ3IuYwo+IEBAIC02MzYsMTAgKzYzNiwxMSBAQCBzdGF0aWMgaW50 IGN6X3NtdV9wb3B1bGF0ZV9maXJtd2FyZV9lbnRyaWVzKHN0cnVjdCBwcF9zbXVtZ3IgKnNtdW1n cikKPiAgCWludCByZXQ7Cj4gIAllbnVtIGNnc191Y29kZV9pZCB1Y29kZV9pZDsKPiAgCXN0cnVj dCBjZ3NfZmlybXdhcmVfaW5mbyBpbmZvID0gezB9Owo+ICsJaW50IG4gPSBBUlJBWV9TSVpFKGZp cm13YXJlX2xpc3QpOwo+ICAKPiAgCWN6X3NtdS0+ZHJpdmVyX2J1ZmZlcl9sZW5ndGggPSAwOwo+ ICAKPiAtCWZvciAoaSA9IDA7IGkgPCBzaXplb2YoZmlybXdhcmVfbGlzdCkvc2l6ZW9mKCpmaXJt d2FyZV9saXN0KTsgaSsrKSB7Cj4gKwlmb3IgKGkgPSAwOyBpIDwgbjsgaSsrKSB7Cj4gIAo+ICAJ CWZpcm13YXJlX3R5cGUgPSBjel90cmFuc2xhdGVfZmlybXdhcmVfZW51bV90b19hcmcoc211bWdy LAo+ICAJCQkJCWZpcm13YXJlX2xpc3RbaV0pOwo+IC0tIAo+IDEuOS4xCj4gCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbcELJs6 (ORCPT ); Thu, 12 May 2016 05:48:58 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:8602 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbcELJs5 (ORCPT ); Thu, 12 May 2016 05:48:57 -0400 Date: Thu, 12 May 2016 10:49:36 +0100 From: Eric Engestrom To: Muhammad Falak R Wani CC: Christian Knig , Nils =?utf-8?Q?Wallm=C3=A9nius?= , Jammy Zhou , , , Alex Deucher , Rex Zhu , Dan Carpenter Subject: Re: [PATCH] drm/amd/powerplay: use ARRAY_SIZE() for size of array Message-ID: <20160512094936.GO7910@imgtec.com> References: <1462988936-13486-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1462988936-13486-1-git-send-email-falakreyaz@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 11, 2016 at 11:18:43PM +0530, Muhammad Falak R Wani wrote: > Use ARRAY_SIZE() for the size calculation of the array. Also move the > condition evaulation function out of the for loop. > Although, any respectable c-compiler would optimize this and evaluate > the function only once outside the loop, but the optimzation engine > of gcc is bit brain-dead, and at times needs some hand holding. `sizeof` is actually a compile-time thing, so at worst, if no optimisation is made, the runtime result is a division of two literals, eg. `for (i = 0; i < 64/8; i++)` (which I doubt any compiler would leave as is anyway) So, +1 on using ARRAY_SIZE, -1 on creating a new variable (which is not even `const` btw) > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > index da18f44..718a551 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c > @@ -636,10 +636,11 @@ static int cz_smu_populate_firmware_entries(struct pp_smumgr *smumgr) > int ret; > enum cgs_ucode_id ucode_id; > struct cgs_firmware_info info = {0}; > + int n = ARRAY_SIZE(firmware_list); > > cz_smu->driver_buffer_length = 0; > > - for (i = 0; i < sizeof(firmware_list)/sizeof(*firmware_list); i++) { > + for (i = 0; i < n; i++) { > > firmware_type = cz_translate_firmware_enum_to_arg(smumgr, > firmware_list[i]); > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel