From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] mkfs.xfs: annotate fallthrough cases in cvtnum
Date: Thu, 12 May 2016 15:59:29 +0200 [thread overview]
Message-ID: <20160512135929.GC28780@redhat.com> (raw)
In-Reply-To: <51117671-6856-0fb7-d86e-0fdf6a29b5e5@sandeen.net>
On Wed, May 11, 2016 at 09:47:45PM -0500, Eric Sandeen wrote:
> We should really collapse our 3 cvtnum variants,
> but for now at least shut up Coverity about this
> intentional case fallthrough.
>
Looks good
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> Addresses-Coverity-ID: 1361553
> Addresses-Coverity-ID: 1361554
> Addresses-Coverity-ID: 1361555
> Addresses-Coverity-ID: 1361556
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 955dcfd..12fe8f3 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3623,14 +3623,19 @@ cvtnum(
> switch (c) {
> case 'e':
> i *= 1024LL;
> + /* fall through */
> case 'p':
> i *= 1024LL;
> + /* fall through */
> case 't':
> i *= 1024LL;
> + /* fall through */
> case 'g':
> i *= 1024LL;
> + /* fall through */
> case 'm':
> i *= 1024LL;
> + /* fall through */
> case 'k':
> return i * 1024LL;
> default:
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-05-12 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 2:47 [PATCH] mkfs.xfs: annotate fallthrough cases in cvtnum Eric Sandeen
2016-05-12 11:50 ` Christoph Hellwig
2016-05-12 13:59 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512135929.GC28780@redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.