From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752923AbcEMDXx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 May 2016 23:23:53 -0400
Received: from mga03.intel.com ([134.134.136.65]:58612 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751510AbcEMDXw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 May 2016 23:23:52 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,612,1455004800"; 
   d="scan'208";a="975423945"
Date: Fri, 13 May 2016 03:42:24 +0800
From: Yuyang Du <yuyang.du@intel.com>
To: morten.rasmussen@arm.com, linux-kernel@vger.kernel.org, efault@gmx.de,
        wanpeng.li@hotmail.com, peterz@infradead.org, hpa@zytor.com,
        torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org
Cc: vincent.guittot@linaro.org, bsegall@google.com
Subject: Re: [tip:sched/core] sched/fair: Clean up scale confusion
Message-ID: <20160512194224.GA22541@intel.com>
References: <tip-1be0eb2a97d756fb7dd8c9baf372d81fa9699c09@git.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tip-1be0eb2a97d756fb7dd8c9baf372d81fa9699c09@git.kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 12, 2016 at 03:31:27AM -0700, tip-bot for Peter Zijlstra wrote:
> Commit-ID:  1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Gitweb:     http://git.kernel.org/tip/1be0eb2a97d756fb7dd8c9baf372d81fa9699c09
> Author:     Peter Zijlstra <peterz@infradead.org>
> AuthorDate: Fri, 6 May 2016 12:21:23 +0200
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 12 May 2016 09:55:33 +0200
> 
> sched/fair: Clean up scale confusion
> 
> Wanpeng noted that the scale_load_down() in calculate_imbalance() was
> weird. I agree, it should be SCHED_CAPACITY_SCALE, since we're going
> to compare against busiest->group_capacity, which is in [capacity]
> units.
>
> Reported-by: Wanpeng Li <wanpeng.li@hotmail.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Morten Rasmussen <morten.rasmussen@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Yuyang Du <yuyang.du@intel.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Ingo Molnar <mingo@kernel.org>

It is good that this issue is addressed and patch merged, however, for the
record, Vincent has already had a solution for this, and we had a patch,
including other cleanups (the latest version is: https://lkml.org/lkml/2016/5/3/925).
And I think Ben first pointed this out (and we then attempted to address it)
as far as I can tell.