From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:57306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbcEMJS5 (ORCPT ); Fri, 13 May 2016 05:18:57 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D9EE10B84B for ; Fri, 13 May 2016 09:18:52 +0000 (UTC) Received: from redhat.com (vpn-55-193.rdu2.redhat.com [10.10.55.193]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4D9Im5N023211 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 13 May 2016 05:18:51 -0400 Date: Fri, 13 May 2016 11:18:48 +0200 From: Carlos Maiolino To: linux-fsdevel@vger.kernel.org Subject: Re: [RFC 1/2] block: allow other bd i_node flags when DAX is disabled Message-ID: <20160513091848.GA4393@redhat.com> References: <1463074986-3070-1-git-send-email-jonathan.derrick@intel.com> <1463074986-3070-2-git-send-email-jonathan.derrick@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463074986-3070-2-git-send-email-jonathan.derrick@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 12, 2016 at 11:43:05AM -0600, Jon Derrick wrote: > When DAX is not compiled into the kernel or the device does not support > direct-access, the block device file's inode flags are fully cleared. > This patch changes it to only clear the S_DAX flag when DAX is disabled. > This patch makes sense to me, despite of the acceptance or not of the S_HIPRI flag, you can add: Reviewed-by: Carlos Maiolino > This reverts to i_flags behavior prior to > bbab37ddc20bae4709bca8745c128c4f46fe63c5 > > Signed-off-by: Jon Derrick > --- > fs/block_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 20a2c02..d4fa725 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -1208,7 +1208,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part) > if (IS_ENABLED(CONFIG_BLK_DEV_DAX) && disk->fops->direct_access) > bdev->bd_inode->i_flags = S_DAX; > else > - bdev->bd_inode->i_flags = 0; > + bdev->bd_inode->i_flags &= ~S_DAX; > > if (!partno) { > ret = -ENXIO; > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos