From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ntelkar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org,
agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
nkaje-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Fri, 13 May 2016 13:48:23 +0200 [thread overview]
Message-ID: <20160513114823.GJ1778@katana> (raw)
In-Reply-To: <1462534274-28925-3-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote:
> Among the bus errors reported from the QUP_MASTER_STATUS register
> only NACK is considered and transfer gets suspended, while
> other errors are ignored. Correct this and suspend the transfer
> for other errors as well. This avoids unnessecary 'timeouts' which
> happens when waiting for events that would never happen when there
> is already an error condition on the bus.
>
> Signed-off-by: Sricharan R <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> Reviewed-by: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Please check Documentation/i2c/fault-codes for proper fault codes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Fri, 13 May 2016 13:48:23 +0200 [thread overview]
Message-ID: <20160513114823.GJ1778@katana> (raw)
In-Reply-To: <1462534274-28925-3-git-send-email-sricharan@codeaurora.org>
On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote:
> Among the bus errors reported from the QUP_MASTER_STATUS register
> only NACK is considered and transfer gets suspended, while
> other errors are ignored. Correct this and suspend the transfer
> for other errors as well. This avoids unnessecary 'timeouts' which
> happens when waiting for events that would never happen when there
> is already an error condition on the bus.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Reviewed-by: Andy Gross <andy.gross@linaro.org>
Please check Documentation/i2c/fault-codes for proper fault codes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160513/ddc2df3f/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Sricharan R <sricharan@codeaurora.org>
Cc: devicetree@vger.kernel.org, architt@codeaurora.org,
linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-i2c@vger.kernel.org,
iivanov@mm-sol.com, agross@codeaurora.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nkaje@codeaurora.org
Subject: Re: [PATCH V2 2/2] drivers: i2c: qup: Fix error handling
Date: Fri, 13 May 2016 13:48:23 +0200 [thread overview]
Message-ID: <20160513114823.GJ1778@katana> (raw)
In-Reply-To: <1462534274-28925-3-git-send-email-sricharan@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Fri, May 06, 2016 at 05:01:14PM +0530, Sricharan R wrote:
> Among the bus errors reported from the QUP_MASTER_STATUS register
> only NACK is considered and transfer gets suspended, while
> other errors are ignored. Correct this and suspend the transfer
> for other errors as well. This avoids unnessecary 'timeouts' which
> happens when waiting for events that would never happen when there
> is already an error condition on the bus.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Reviewed-by: Andy Gross <andy.gross@linaro.org>
Please check Documentation/i2c/fault-codes for proper fault codes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-13 11:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 11:31 [PATCH V2 0/2] drivers: i2c: qup: Some misc fixes Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 11:31 ` [PATCH V2 1/2] drivers: i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is enabled Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 17:36 ` [V2, " Naveen Kaje
2016-05-06 17:36 ` Naveen Kaje
2016-05-13 11:47 ` [PATCH V2 " Wolfram Sang
2016-05-13 11:47 ` Wolfram Sang
2016-05-16 5:19 ` Sricharan
2016-05-16 5:19 ` Sricharan
2016-05-16 5:19 ` Sricharan
2016-05-06 11:31 ` [PATCH V2 2/2] drivers: i2c: qup: Fix error handling Sricharan R
2016-05-06 11:31 ` Sricharan R
2016-05-06 17:53 ` [V2,2/2] " Naveen Kaje
2016-05-06 17:53 ` Naveen Kaje
[not found] ` <1462534274-28925-3-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-05-13 11:48 ` Wolfram Sang [this message]
2016-05-13 11:48 ` [PATCH V2 2/2] " Wolfram Sang
2016-05-13 11:48 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-13 11:50 ` Wolfram Sang
2016-05-16 5:59 ` Sricharan
2016-05-16 5:59 ` Sricharan
2016-05-16 5:59 ` Sricharan
2016-05-13 11:44 ` [PATCH V2 0/2] drivers: i2c: qup: Some misc fixes Wolfram Sang
2016-05-13 11:44 ` Wolfram Sang
2016-05-16 5:13 ` Sricharan
2016-05-16 5:13 ` Sricharan
2016-05-16 5:13 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513114823.GJ1778@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nkaje-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ntelkar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.