All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Joerg Roedel <jroedel@suse.de>,
	Jacek Lawrynowicz <jacek.lawrynowicz@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	linux-pci@vger.kernel.org
Subject: Build breakage for pci-next since v4.6-rc5
Date: Fri, 13 May 2016 13:56:42 +0200	[thread overview]
Message-ID: <20160513115642.GA22906@wunner.de> (raw)

Hi Jacek, Hi Jörg,

in case this isn't on your radar yet, Bjorn Helgaas' next branch
currently no longer builds when merged with Linus' master branch
because this commit introduced with v4.6-rc5:

    commit e3156048346c28c695f5cf9db67a8cf88c90f947
    Author: Joerg Roedel <jroedel@suse.de>
    Date:   Fri Apr 8 15:12:24 2016 +0200
    iommu/amd: Fix checking of pci dma aliases

adds an occurrence of PCI_DEV_FLAGS_DMA_ALIAS_DEVFN but this
commit on Bjorn's next branch:

    commit 338c3149a221527e202ee26b1e35f76c965bb6c0
    Author: Jacek Lawrynowicz <jacek.lawrynowicz@intel.com>
    Date:   Thu Mar 3 15:38:02 2016 +0100
    PCI: Add support for multiple DMA aliases

removed all other occurrences of this macro. A rebase of the
latter commit is required to fix the build breakage. I was
made aware of this yesterday by Intel's 0-DAY kernel test
infrastructure (see below).

Thanks,

Lukas

----- Forwarded message from kbuild test robot <fengguang.wu@intel.com> -----

Date: Thu, 12 May 2016 21:38:46 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: kbuild-all@01.org, Lukas Wunner <lukas@wunner.de>
Subject: [l1k:thunderbolt_runpm_v2 1/14] drivers/iommu/amd_iommu.c:266:22:
	error: 'PCI_DEV_FLAGS_DMA_ALIAS_DEVFN' undeclared
User-Agent: Mutt/1.5.23 (2014-03-12)

tree:   https://github.com/l1k/linux thunderbolt_runpm_v2
head:   308f7c892de104a57f50dda4761c10c094f5e80d
commit: 376a0f25bf07bdd90c58985f210c95a59d21fe1b [1/14] Merge remote-tracking branches 'helgaas/next', 'helgaas/for-linus' and 'helgaas/pci/pm' into HEAD
config: x86_64-rhel (attached as .config)
compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3
reproduce:
        git checkout 376a0f25bf07bdd90c58985f210c95a59d21fe1b
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: the l1k/thunderbolt_runpm_v2 HEAD 308f7c892de104a57f50dda4761c10c094f5e80d builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/iommu/amd_iommu.c: In function 'get_alias':
>> drivers/iommu/amd_iommu.c:266:22: error: 'PCI_DEV_FLAGS_DMA_ALIAS_DEVFN' undeclared (first use in this function)
      pdev->dev_flags |= PCI_DEV_FLAGS_DMA_ALIAS_DEVFN;
                         ^
   drivers/iommu/amd_iommu.c:266:22: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/iommu/amd_iommu.c:267:7: error: 'struct pci_dev' has no member named 'dma_alias_devfn'
      pdev->dma_alias_devfn = ivrs_alias & 0xff;
          ^

vim +/PCI_DEV_FLAGS_DMA_ALIAS_DEVFN +266 drivers/iommu/amd_iommu.c

e3156048 Joerg Roedel 2016-04-08  260  	/*
e3156048 Joerg Roedel 2016-04-08  261  	 * If we don't have a PCI DMA alias and the IVRS alias is on the same
e3156048 Joerg Roedel 2016-04-08  262  	 * bus, then the IVRS table may know about a quirk that we don't.
e3156048 Joerg Roedel 2016-04-08  263  	 */
e3156048 Joerg Roedel 2016-04-08  264  	if (pci_alias == devid &&
e3156048 Joerg Roedel 2016-04-08  265  	    PCI_BUS_NUM(ivrs_alias) == pdev->bus->number) {
e3156048 Joerg Roedel 2016-04-08 @266  		pdev->dev_flags |= PCI_DEV_FLAGS_DMA_ALIAS_DEVFN;
e3156048 Joerg Roedel 2016-04-08 @267  		pdev->dma_alias_devfn = ivrs_alias & 0xff;
e3156048 Joerg Roedel 2016-04-08  268  		pr_info("AMD-Vi: Added PCI DMA alias %02x.%d for %s\n",
e3156048 Joerg Roedel 2016-04-08  269  			PCI_SLOT(ivrs_alias), PCI_FUNC(ivrs_alias),
e3156048 Joerg Roedel 2016-04-08  270  			dev_name(dev));

:::::: The code at line 266 was first introduced by commit
:::::: e3156048346c28c695f5cf9db67a8cf88c90f947 iommu/amd: Fix checking of pci dma aliases

:::::: TO: Joerg Roedel <jroedel@suse.de>
:::::: CC: Joerg Roedel <jroedel@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



----- End forwarded message -----

             reply	other threads:[~2016-05-13 11:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-13 11:56 Lukas Wunner [this message]
2016-05-13 12:25 ` Build breakage for pci-next since v4.6-rc5 Lawrynowicz, Jacek
2016-05-16 20:10   ` Bjorn Helgaas
2016-05-17  9:55     ` [PATCH] PCI: Fix merge conflict in amd_iommu.c Jacek Lawrynowicz
2016-05-17 10:17     ` Build breakage for pci-next since v4.6-rc5 Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160513115642.GA22906@wunner.de \
    --to=lukas@wunner.de \
    --cc=alex.williamson@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=jacek.lawrynowicz@intel.com \
    --cc=jroedel@suse.de \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.