From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next] IB/IPoIB: Allow setting the device address Date: Fri, 13 May 2016 10:45:48 -0600 Message-ID: <20160513164548.GA27209@obsidianresearch.com> References: <1462340207-16174-1-git-send-email-leon@kernel.org> <20160504184105.GB20554@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Bloch Cc: Leon Romanovsky , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Majd Dibbiny , Matan Barak List-Id: linux-rdma@vger.kernel.org On Tue, May 10, 2016 at 03:26:27PM +0000, Mark Bloch wrote: > > Did these checks from eth_prepare_mac_addr_change get included? > > > > if (!(dev->priv_flags & IFF_LIVE_ADDR_CHANGE) && > > netif_running(dev)) > > return -EBUSY; > > > Why do I need to include that? That is standard in all the other implementations - you should be asking instead why IPoIB doesn't need to copy that. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html