From: keith.busch@intel.com (Keith Busch)
Subject: Hang Condition in nvme_ns_remove
Date: Fri, 13 May 2016 17:03:03 -0400 [thread overview]
Message-ID: <20160513210302.GA14531@localhost.localdomain> (raw)
In-Reply-To: <BL2PR04MB163363775AA16EECA5666CE92740@BL2PR04MB163.namprd04.prod.outlook.com>
On Fri, May 13, 2016@08:52:15PM +0000, Jeff Lien wrote:
> I encountered another hang condition in the nvme_ns_remove function. It's caused when nvme_ns_remove is called by nvme_scan_namespaces/__nvme_scan_namespaces. In nvme_scan_namespaces, the namespaces_mutex is locked; nvme_ns_remove will also try to get that mutex right before the call to list_del_init. When that handles it hangs there.
>
> It could be fixed by removing the mutex_lock call in nvme_ns_remove and then changing the code so that all other callers of ns_remove get the lock instead. Since I'm not real familiar with this part of the code, I don't know if this is the best fix or not. Asking for your input on that.
Should be fixed if you pick up this commit (and any dependencies):
https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit?id=b7b9c2278752e37dc7ae918cda823aa2a078e03b
prev parent reply other threads:[~2016-05-13 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:52 Hang Condition in nvme_ns_remove Jeff Lien
2016-05-13 21:03 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513210302.GA14531@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.