From: Brian Norris <briannorris@chromium.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Doug Anderson <dianders@chromium.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399
Date: Fri, 13 May 2016 14:57:24 -0700 [thread overview]
Message-ID: <20160513215724.GB109473@google.com> (raw)
In-Reply-To: <5607915.FAWxOoA1QB@phil>
On Fri, May 13, 2016 at 11:47:57PM +0200, Heiko Stuebner wrote:
> Am Donnerstag, 12. Mai 2016, 15:35:51 schrieb Brian Norris:
> > Add description for the SDHCI v5.1 eMMC controller on rk3399. Fix it to
> > 200 MHz, to support all supported timing modes.
> >
> > Note that 'rockchip,rk3399-sdhci-5.1' is not documented; we presumably
> > have a compliant Arasan controller, but let's have a rockchip property
> > as the canonical backup/precautionary measure. Per Heiko's previous
> > suggestion, let's not clutter the arasan doc with it.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> At least one split is necessary.
> So please at least split out the simple-mfd addition into a separate patch
Will do.
BTW, should this be noted in
Documentation/devicetree/bindings/soc/rockchip/grf.txt now?
> (I should've seen that in v1 already, but sadly didn't)
No problem.
> I'm undecided if the emmc-phy addition also should get its own patch, but I
> guess it can stay together with the emmc controller.
I think it makes sense for them to stay together. What's a phy without a
controller to use it? :)
Brian
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399
Date: Fri, 13 May 2016 14:57:24 -0700 [thread overview]
Message-ID: <20160513215724.GB109473@google.com> (raw)
In-Reply-To: <5607915.FAWxOoA1QB@phil>
On Fri, May 13, 2016 at 11:47:57PM +0200, Heiko Stuebner wrote:
> Am Donnerstag, 12. Mai 2016, 15:35:51 schrieb Brian Norris:
> > Add description for the SDHCI v5.1 eMMC controller on rk3399. Fix it to
> > 200 MHz, to support all supported timing modes.
> >
> > Note that 'rockchip,rk3399-sdhci-5.1' is not documented; we presumably
> > have a compliant Arasan controller, but let's have a rockchip property
> > as the canonical backup/precautionary measure. Per Heiko's previous
> > suggestion, let's not clutter the arasan doc with it.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> At least one split is necessary.
> So please at least split out the simple-mfd addition into a separate patch
Will do.
BTW, should this be noted in
Documentation/devicetree/bindings/soc/rockchip/grf.txt now?
> (I should've seen that in v1 already, but sadly didn't)
No problem.
> I'm undecided if the emmc-phy addition also should get its own patch, but I
> guess it can stay together with the emmc controller.
I think it makes sense for them to stay together. What's a phy without a
controller to use it? :)
Brian
next prev parent reply other threads:[~2016-05-13 21:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 22:35 [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Brian Norris
2016-05-12 22:35 ` Brian Norris
2016-05-12 22:35 ` Brian Norris
2016-05-12 22:35 ` [PATCH v2 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB Brian Norris
2016-05-12 22:35 ` Brian Norris
2016-05-12 22:35 ` Brian Norris
2016-05-13 21:49 ` Heiko Stuebner
2016-05-13 21:49 ` Heiko Stuebner
[not found] ` <1463092552-60696-1-git-send-email-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-05-13 0:42 ` [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Shawn Lin
2016-05-13 0:42 ` Shawn Lin
2016-05-13 0:42 ` Shawn Lin
2016-05-13 21:42 ` Doug Anderson
2016-05-13 21:42 ` Doug Anderson
2016-05-13 21:48 ` Brian Norris
2016-05-13 21:48 ` Brian Norris
2016-05-13 21:47 ` Heiko Stuebner
2016-05-13 21:47 ` Heiko Stuebner
2016-05-13 21:57 ` Brian Norris [this message]
2016-05-13 21:57 ` Brian Norris
2016-05-13 22:14 ` Heiko Stuebner
2016-05-13 22:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513215724.GB109473@google.com \
--to=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.