Re: [RFC 8/8] xattr: Remove generic xattr handlers

[Al Viro <viro@ZenIV.linux.org.uk>]

On Tue, May 03, 2016 at 12:45:18AM +0200, Andreas Gruenbacher wrote:

> diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c
> index bb9549b..4b7a510 100644
> --- a/fs/hfs/inode.c
> +++ b/fs/hfs/inode.c
> @@ -687,7 +687,5 @@ static const struct file_operations hfs_file_operations = {
>  static const struct inode_operations hfs_file_inode_operations = {
>  	.lookup		= hfs_file_lookup,
>  	.setattr	= hfs_inode_setattr,
> -	.setxattr	= generic_setxattr,
> -	.getxattr	= generic_getxattr,

Where has that come from?  I don't see anything else in your series touching
that file and work.xattr doesn't touch it either.  With
static const struct inode_operations hfs_file_inode_operations = {
        .lookup         = hfs_file_lookup,
        .setattr        = hfs_inode_setattr,
        .setxattr       = hfs_setxattr,
        .getxattr       = hfs_getxattr,
        .listxattr      = hfs_listxattr,
};
being what's in the tree.  And it *is* an interesting one, seeing that this
is one case where some inodes on a given fs do have ->...xattr and some do
not, so I'd like to see the details.