From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] android-tools: fix dependency on libselinux
Date: Sun, 15 May 2016 21:21:35 +0200 [thread overview]
Message-ID: <20160515212135.4d85f193@free-electrons.com> (raw)
In-Reply-To: <1463235434-31134-1-git-send-email-thomas.petazzoni@free-electrons.com>
Hello,
On Sat, 14 May 2016 16:17:11 +0200, Thomas Petazzoni wrote:
> The fastboot sub-option of android-tools did not properly replicate the
> dependency of libselinux, which it is selecting. Due to this, an invalid
> configuration could be generated, with fastboot selected while thread
> support is not available for example (and therefore libselinux is not
> available). This problem was causing the following build failure:
>
> http://autobuild.buildroot.net/results/21e45cee04fd983c85c6702595ee3f7ed8470931/
>
> This is fixed by replicating the selinux dependencies in the fastboot
> sub-option and adding the relevant Config.in comment.
>
> In addition, the main android-tools option had some logic to make sure
> at least one of its sub-option is enabled: adbd by default on systems
> with MMU, and fastboot by default on systems without MMU (because
> fastboot is the only part that builds on noMMU systems).
>
> However, with the new dependencies in the fastboot sub-option, this
> logic would have become a lot more complicated. Since fastboot is very
> unlikely to be used on noMMU systems, we simply make the whole package
> not available on noMMU systems.
>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
> Cc: Julien Corjon <corjon.j@ecagroup.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/android-tools/Config.in | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
Applied to master.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-05-15 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 14:17 [Buildroot] [PATCH 1/4] android-tools: fix dependency on libselinux Thomas Petazzoni
2016-05-14 14:17 ` [Buildroot] [PATCH 2/4] android-tools: fix build on big endian systems Thomas Petazzoni
2016-05-17 13:47 ` Peter Korsgaard
2016-05-14 14:17 ` [Buildroot] [PATCH 3/4] cups: fix static linking problem Thomas Petazzoni
2016-05-17 8:47 ` Olivier Schonken
2016-05-25 20:47 ` Peter Korsgaard
2016-05-14 14:17 ` [Buildroot] [PATCH 4/4] gmrender-resurrect: disable on musl configurations Thomas Petazzoni
2016-05-14 23:45 ` Arnout Vandecappelle
2016-05-15 19:22 ` Thomas Petazzoni
2016-05-14 23:31 ` [Buildroot] [PATCH 1/4] android-tools: fix dependency on libselinux Arnout Vandecappelle
2016-05-15 19:21 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160515212135.4d85f193@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.