From: Wei Liu <wei.liu2@citrix.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Peng Fan <van.freenix@gmail.com>,
sstabellini@kernel.org, Wei Liu <wei.liu2@citrix.com>,
Xen Devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings
Date: Mon, 16 May 2016 10:39:53 +0100 [thread overview]
Message-ID: <20160516093953.GJ8974@citrix.com> (raw)
In-Reply-To: <5739948B.4020707@arm.com>
On Mon, May 16, 2016 at 10:36:11AM +0100, Julien Grall wrote:
> (CC Wei for Xen 4.7)
>
> Hi,
>
> On 12/05/16 14:03, Peng Fan wrote:
> >On ARM64, "frametable_size >> SECOND_SHIFT" computes the number
> >of second level entries, not the number of second level pages.
> >
> >"ROUNDUP(frametable_size, FIRST_SIZE) >> FIRST_SHIFT" which computes
> >the number of the first level entries (the number of second level pages),
> >is the correct one that should be used.
> >
> >Signed-off-by: Peng Fan <van.freenix@gmail.com>
> >Cc: Stefano Stabellini <sstabellini@kernel.org>
> >Cc: Julien Grall <julien.grall@arm.com>
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-05-16 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 13:03 [PATCH V2] xen/arm: mm: fix nr_second calculation in setup_frametable_mappings Peng Fan
2016-05-16 9:36 ` Julien Grall
2016-05-16 9:39 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516093953.GJ8974@citrix.com \
--to=wei.liu2@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.