From: Baoquan He <bhe@redhat.com>
To: Corey Minyard <minyard@acm.org>
Cc: Corey Minyard <cminyard@mvista.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Haren Myneni <hbabu@us.ibm.com>,
dyoung@redhat.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v2] kdump: Fix gdb macros work work with newer and 64-bit kernels
Date: Mon, 16 May 2016 20:23:42 +0800 [thread overview]
Message-ID: <20160516122342.GG7214@x1.redhat.com> (raw)
In-Reply-To: <5739B478.5010205@acm.org>
On 05/16/16 at 06:52am, Corey Minyard wrote:
> On 05/16/2016 04:32 AM, Baoquan He wrote:
> >On 05/10/16 at 07:30pm, minyard@acm.org wrote:
> >>From: Corey Minyard <cminyard@mvista.com>
> >>
> >>Lots of little changes needed to be made to clean these up, remove the
> >>four byte pointer assumption and traverse the pid queue properly.
> >>Also consolidate the traceback code into a single function instead
> >>of having three copies of it.
> >>
> >>Signed-off-by: Corey Minyard <cminyard@mvista.com>
> >Hi Corey,
> >
> >Today I tried gdbmacro.txt and found dmesg doesn't work. I tested it
> >on the latest 4.6.0 kernel. And I directly copy /proc/vmcore out
> >and use gdb to open it by below command"
> >
> >gdb vmlinux /var/crash/vmcore --"gdbmacros.txt"
> >
> >All macro functions work well except of dmesg since code inside refer to
> >the deprecated variable like "log_end" and "logged_chars". But these
> >have been changed since this commit:
> >
> >commit 7ff9554bb578ba02166071d2d487b7fc7d860d62
> >Author: Kay Sievers <kay@vrfy.org>
> >Date: Thu May 3 02:29:13 2012 +0200
> >
> > printk: convert byte-buffer to variable-length record buffer
> >
> >So invoking dmesg will cause an error message printing out:
> >
> >(gdb) dmesg
> >No symbol "log_end" in current context.
>
> Yes, I was actually aware of that, but that's a different issue and I
> hadn't thought about it much.
Got it. Then fixes covered by this patch looks good. Ack it, thanks
for this effort.
Acked-by: Baoquan He <bhe@redhat.com>
Thanks
Baoquan
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Corey Minyard <minyard@acm.org>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Vivek Goyal <vgoyal@redhat.com>, Haren Myneni <hbabu@us.ibm.com>,
Corey Minyard <cminyard@mvista.com>,
dyoung@redhat.com
Subject: Re: [PATCH v2] kdump: Fix gdb macros work work with newer and 64-bit kernels
Date: Mon, 16 May 2016 20:23:42 +0800 [thread overview]
Message-ID: <20160516122342.GG7214@x1.redhat.com> (raw)
In-Reply-To: <5739B478.5010205@acm.org>
On 05/16/16 at 06:52am, Corey Minyard wrote:
> On 05/16/2016 04:32 AM, Baoquan He wrote:
> >On 05/10/16 at 07:30pm, minyard@acm.org wrote:
> >>From: Corey Minyard <cminyard@mvista.com>
> >>
> >>Lots of little changes needed to be made to clean these up, remove the
> >>four byte pointer assumption and traverse the pid queue properly.
> >>Also consolidate the traceback code into a single function instead
> >>of having three copies of it.
> >>
> >>Signed-off-by: Corey Minyard <cminyard@mvista.com>
> >Hi Corey,
> >
> >Today I tried gdbmacro.txt and found dmesg doesn't work. I tested it
> >on the latest 4.6.0 kernel. And I directly copy /proc/vmcore out
> >and use gdb to open it by below command"
> >
> >gdb vmlinux /var/crash/vmcore --"gdbmacros.txt"
> >
> >All macro functions work well except of dmesg since code inside refer to
> >the deprecated variable like "log_end" and "logged_chars". But these
> >have been changed since this commit:
> >
> >commit 7ff9554bb578ba02166071d2d487b7fc7d860d62
> >Author: Kay Sievers <kay@vrfy.org>
> >Date: Thu May 3 02:29:13 2012 +0200
> >
> > printk: convert byte-buffer to variable-length record buffer
> >
> >So invoking dmesg will cause an error message printing out:
> >
> >(gdb) dmesg
> >No symbol "log_end" in current context.
>
> Yes, I was actually aware of that, but that's a different issue and I
> hadn't thought about it much.
Got it. Then fixes covered by this patch looks good. Ack it, thanks
for this effort.
Acked-by: Baoquan He <bhe@redhat.com>
Thanks
Baoquan
next prev parent reply other threads:[~2016-05-16 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 0:30 [PATCH v2] kdump: Fix gdb macros work work with newer and 64-bit kernels minyard
2016-05-11 0:30 ` minyard
2016-05-16 9:32 ` Baoquan He
2016-05-16 9:32 ` Baoquan He
2016-05-16 9:44 ` Baoquan He
2016-05-16 9:44 ` Baoquan He
2016-05-16 11:52 ` Corey Minyard
2016-05-16 11:52 ` Corey Minyard
2016-05-16 12:23 ` Baoquan He [this message]
2016-05-16 12:23 ` Baoquan He
2016-05-16 12:48 ` Baoquan He
2016-05-16 12:48 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516122342.GG7214@x1.redhat.com \
--to=bhe@redhat.com \
--cc=cminyard@mvista.com \
--cc=dyoung@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.