From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size. Date: Mon, 16 May 2016 16:53:50 +0100 Message-ID: <20160516155350.GQ7910@imgtec.com> References: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id 106D76E38B for ; Mon, 16 May 2016 15:53:06 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Muhammad Falak R Wani Cc: Nils =?utf-8?Q?Wallm=C3=A9nius?= , Jammy Zhou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Rex Zhu , Christian =?utf-8?B?S8O2bmln?= , Dan Carpenter List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXkgMTMsIDIwMTYgYXQgMTE6MDY6NDBQTSArMDUzMCwgTXVoYW1tYWQgRmFsYWsg UiBXYW5pIHdyb3RlOgo+IEl0IGlzIHByZWZlcnJlZCB0byB1c2UgQVJSQVlfU0laRSgpIGZvciBz aXplIGNhbGN1bGF0aW9uLCBpbnN0ZWFkCj4gdXNpbmcgc2l6ZW9mKGFycmF5KS9zaXplb2YoKmFy cmF5KS4gSXQgbWFrZXMgdGhlIGNvZGUgbW9yZSByZWFkYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBNdWhhbW1hZCBGYWxhayBSIFdhbmkgPGZhbGFrcmV5YXpAZ21haWwuY29tPgoKUmV2aWV3ZWQt Ynk6IEVyaWMgRW5nZXN0cm9tIDxlcmljLmVuZ2VzdHJvbUBpbWd0ZWMuY29tPgoKVGhhbmtzLCBh bmQgc29ycnkgYWJvdXQgYmVmb3JlLCBpZiBJIG1hZGUgeW91IGZlZWwgbGlrZSB5b3UgbWFkZQph ICJjaGlsZGlzaCBtaXN0YWtlIi4gQXMgRGFuIHNhaWQsIHRoaXMgaXMgbW9zdGx5IGEgcXVlc3Rp b24gb2YKc3R5bGU6IHlvdXIgY29kZSB3YXMgcmlnaHQsIGl0IGp1c3QgaGFkIGFuIHVubmVjZXNz YXJ5IGJpdC4KCkkgaG9wZSBJIGRpZG4ndCBnaXZlIHlvdSBhIGJhZCBpbXByZXNzaW9uIG9mIHRo ZSBjb21tdW5pdHksIG1vc3QKcGVvcGxlIGFyb3VuZCBoZXJlIGhhdmUgYmV0dGVyIG1hbm5lcnMg dGhhbiBJIDpQCgpDaGVlcnMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbcEPPxI (ORCPT ); Mon, 16 May 2016 11:53:08 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:28478 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752202AbcEPPxH (ORCPT ); Mon, 16 May 2016 11:53:07 -0400 Date: Mon, 16 May 2016 16:53:50 +0100 From: Eric Engestrom To: Muhammad Falak R Wani CC: David Airlie , Nils =?utf-8?Q?Wallm=C3=A9nius?= , Jammy Zhou , , , Alex Deucher , Rex Zhu , Christian =?utf-8?B?S8O2bmln?= , Dan Carpenter Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size. Message-ID: <20160516155350.GQ7910@imgtec.com> References: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote: > It is preferred to use ARRAY_SIZE() for size calculation, instead > using sizeof(array)/sizeof(*array). It makes the code more readable. > > Signed-off-by: Muhammad Falak R Wani Reviewed-by: Eric Engestrom Thanks, and sorry about before, if I made you feel like you made a "childish mistake". As Dan said, this is mostly a question of style: your code was right, it just had an unnecessary bit. I hope I didn't give you a bad impression of the community, most people around here have better manners than I :P Cheers