From: Denys Dmytriyenko <denys@ti.com>
To: "Nelson, Sam" <sam.nelson@ti.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [PATCH] linux-ti-staging: Add new device tree target am572x-idk-pru-excl-uio.dtb
Date: Mon, 16 May 2016 12:05:04 -0400 [thread overview]
Message-ID: <20160516160504.GI16188@edge> (raw)
In-Reply-To: <4F9216F96E5DF9428610502835A9F490583B8603@DLEE11.ent.ti.com>
On Sun, May 15, 2016 at 11:38:47PM -0400, Nelson, Sam wrote:
>
>
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Sunday, May 15, 2016 11:32 PM
> > To: Nelson, Sam
> > Cc: meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [PATCH] linux-ti-staging: Add new device tree target
> > am572x-idk-pru-excl-uio.dtb
> >
> > See below.
> >
> >
> > On Sun, May 15, 2016 at 11:10:32PM -0400, Sam Nelson wrote:
> > > This new device tree file is to support pruss with uio based drivers.
> > > Adds uio entries for pruss susbsystem.
> > >
> > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > ---
> > > .../linux/files/dra7xx/am572x-pru-uio.dtsi | 191
> > +++++++++++++++++++++
> > > recipes-kernel/linux/linux-ti-staging_4.4.bb | 2 +-
> > > recipes-kernel/linux/ti-uio.inc | 12 ++
> > > 3 files changed, 204 insertions(+), 1 deletion(-) create mode 100644
> > > recipes-kernel/linux/files/dra7xx/am572x-pru-uio.dtsi
> > >
> > > diff --git a/recipes-kernel/linux/files/dra7xx/am572x-pru-uio.dtsi
> > > b/recipes-kernel/linux/files/dra7xx/am572x-pru-uio.dtsi
> > > new file mode 100644
> > > index 0000000..001cbec
> > > --- /dev/null
> > > +++ b/recipes-kernel/linux/files/dra7xx/am572x-pru-uio.dtsi
> > > @@ -0,0 +1,191 @@
> > > +/ {
> > > + ocp {
> > > + pruss2_eth {
> > > + status = "disabled";
> > > + };
> > > + uio_pruss1_mem: uio_pruss1_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + ti,hwmods = "pruss1";
> > > + mem = <0x4b200000 0x2000>,
> > > + <0x4b202000 0x2000>,
> > > + <0x4b210000 0x8000>,
> > > + <0x4b220000 0x2000>,
> > > + <0x4b226000 0x2000>,
> > > + <0x4b22e000 0x31c>,
> > > + <0x4b232000 0x58>;
> > > + mem-names = "dram0", "dram1", "shrdram2", "intc",
> > "cfg",
> > > + "iep", "mii_rt";
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt0: uio_pruss1_evt0 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt1: uio_pruss1_evt1 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt2: uio_pruss1_evt2 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt3: uio_pruss1_evt3 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt4: uio_pruss1_evt4 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt5: uio_pruss1_evt5 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt6: uio_pruss1_evt6 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss1_evt7: uio_pruss1_evt7 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > +
> > > + uio_pruss1_0_mem: uio_pruss1_0_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b234000 0x3000>,
> > > + <0x4b222000 0x400>,
> > > + <0x4b222400 0x100>;
> > > + mem-names = "iram", "control", "debug";
> > > + status = "okay";
> > > + };
> > > +
> > > + uio_pruss1_1_mem: uio_pruss1_1_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b238000 0x3000>,
> > > + <0x4b224000 0x400>,
> > > + <0x4b224400 0x100>;
> > > + mem-names = "iram", "control", "debug";
> > > + status = "okay";
> > > + };
> > > +
> > > + uio_pruss1_mdio: uio_pruss1_mdio {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b232400 0x90>;
> > > + status = "okay";
> > > + };
> > > +
> > > + uio_pruss2_mem: uio_pruss2_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + ti,hwmods = "pruss2";
> > > + mem = <0x4b280000 0x2000>,
> > > + <0x4b282000 0x2000>,
> > > + <0x4b290000 0x8000>,
> > > + <0x4b2a0000 0x2000>,
> > > + <0x4b2a6000 0x2000>,
> > > + <0x4b2ae000 0x31c>,
> > > + <0x4b2b2000 0x58>;
> > > + mem-names = "dram0", "dram1", "shrdram2", "intc",
> > "cfg",
> > > + "iep", "mii_rt";
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt0: uio_pruss2_evt0 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt1: uio_pruss2_evt1 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt2: uio_pruss2_evt2 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt3: uio_pruss2_evt3 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt4: uio_pruss2_evt4 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt5: uio_pruss2_evt5 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt6: uio_pruss2_evt6 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_evt7: uio_pruss2_evt7 {
> > > + compatible = "ti,uio-module-drv";
> > > + interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
> > > + status = "okay";
> > > + };
> > > +
> > > + uio_pruss2_0_mem: uio_pruss2_0_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b2b4000 0x3000>,
> > > + <0x4b2a2000 0x400>,
> > > + <0x4b2a2400 0x100>;
> > > + mem-names = "iram", "control", "debug";
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_1_mem: uio_pruss2_1_mem {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b2b8000 0x3000>,
> > > + <0x4b2a4000 0x400>,
> > > + <0x4b2a4400 0x100>;
> > > + mem-names = "iram", "control", "debug";
> > > + status = "okay";
> > > + };
> > > + uio_pruss2_mdio: uio_pruss2_mdio {
> > > + compatible = "ti,uio-module-drv";
> > > + mem = <0x4b2b2400 0x90>;
> > > + mem-names = "mdio";
> > > + status = "okay";
> > > + };
> > > + };
> > > +};
> > > +
> > > +&pruss1 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pru1_0 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pru1_1 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pruss2 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pru2_0 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pru2_1 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&pruss2_mdio {
> > > + status = "disabled";
> > > +};
> > > diff --git a/recipes-kernel/linux/linux-ti-staging_4.4.bb
> > > b/recipes-kernel/linux/linux-ti-staging_4.4.bb
> > > index a9b99c0..620a789 100644
> > > --- a/recipes-kernel/linux/linux-ti-staging_4.4.bb
> > > +++ b/recipes-kernel/linux/linux-ti-staging_4.4.bb
> > > @@ -52,7 +52,7 @@ KERNEL_DEVICETREE_beaglebone = "am335x-
> > bone.dtb
> > > am335x-boneblack.dtb am335x-bone KERNEL_DEVICETREE_omap5-evm =
> > "omap5-uevm.dtb"
> > > KERNEL_DEVICETREE_dra7xx-evm = "dra7-evm.dtb dra7-evm-lcd-lg.dtb
> > dra7-evm-lcd-osd.dtb dra72-evm.dtb dra72-evm-revc.dtb dra72-evm-lcd-
> > lg.dtb dra72-evm-lcd-osd.dtb"
> > > KERNEL_DEVICETREE_dra7xx-hs-evm = "${KERNEL_DEVICETREE_dra7xx-
> > evm}"
> > > -KERNEL_DEVICETREE_am57xx-evm = "am57xx-beagle-x15.dtb am57xx-
> > beagle-x15-revb1.dtb am57xx-evm.dtb am57xx-evm-reva3.dtb am571x-
> > idk.dtb am572x-idk.dtb am571x-idk-lcd-osd.dtb am572x-idk-lcd-osd.dtb"
> > > +KERNEL_DEVICETREE_am57xx-evm = "am57xx-beagle-x15.dtb am57xx-
> > beagle-x15-revb1.dtb am57xx-evm.dtb am57xx-evm-reva3.dtb am571x-
> > idk.dtb am572x-idk.dtb am571x-idk-lcd-osd.dtb am572x-idk-lcd-osd.dtb
> > am572x-idk-pru-excl-uio.dtb"
> >
> > NACK, you are adding it here unconditionally.
>
> Are you expecting this to be conditional to ENABLE_TI_UIO_DEVICES?
> Please clarify.
The rest of your code is, isn't it?
> > > KERNEL_DEVICETREE_omap3 = "omap3-beagle.dtb omap3-beagle-xm.dtb
> > omap3-beagle-xm-ab.dtb omap3-evm.dtb omap3-evm-37xx.dtb am3517-
> > evm.dtb"
> > > KERNEL_DEVICETREE_am3517-evm = "am3517-evm.dtb"
> > > KERNEL_DEVICETREE_am37x-evm = "omap3-evm-37xx.dtb"
> > > diff --git a/recipes-kernel/linux/ti-uio.inc
> > > b/recipes-kernel/linux/ti-uio.inc index 776e4a4..4764d78 100644
> > > --- a/recipes-kernel/linux/ti-uio.inc
> > > +++ b/recipes-kernel/linux/ti-uio.inc
> > > @@ -2,6 +2,7 @@ SRC_URI_append_keystone = " file://keystone-uio.dtsi"
> > > SRC_URI_append_k2hk-evm = " file://k2hk-uio.dtsi"
> > > SRC_URI_append_k2l-evm = " file://k2l-uio.dtsi"
> > > SRC_URI_append_k2e-evm = " file://k2e-uio.dtsi"
> > > +SRC_URI_append_am57xx-evm = " file://am572x-pru-uio.dtsi"
> > >
> > > DTSI_LIST = ""
> > > DTSI_LIST_append_keystone = " keystone-uio.dtsi"
> > > @@ -24,4 +25,15 @@ do_setup_uio() {
> > > fi
> > > }
> > >
> > > +do_setup_uio_append_am57xx-evm() {
> > > + dts="am572x-idk-pru-excl-uio.dts"
> > > + dtsi="am572x-pru-uio.dtsi"
> > > + cp ${S}/arch/arm/boot/dts/am572x-idk.dts ${S}/arch/arm/boot/dts/$dts
> > > + if [ "${ENABLE_TI_UIO_DEVICES}" == "1" ]
> > > + then
> > > + cp ${WORKDIR}/${dtsi} ${S}/arch/arm/boot/dts/
> > > + echo "#include \"${dtsi}\"" >> ${S}/arch/arm/boot/dts/$dts
> > > + fi
> > > +}
> > > +
> > > do_patch[postfuncs] += "do_setup_uio"
> > > --
> > > 1.9.1
> > >
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti@yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
next prev parent reply other threads:[~2016-05-16 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 3:10 [PATCH] linux-ti-staging: Add new device tree target am572x-idk-pru-excl-uio.dtb Sam Nelson
2016-05-16 3:32 ` Denys Dmytriyenko
2016-05-16 3:38 ` Nelson, Sam
2016-05-16 16:05 ` Denys Dmytriyenko [this message]
2016-05-16 19:11 ` Nelson, Sam
2016-05-16 19:21 ` Denys Dmytriyenko
2016-05-16 21:00 ` Nelson, Sam
2016-05-16 21:14 ` Denys Dmytriyenko
2016-05-16 22:37 ` Nelson, Sam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516160504.GI16188@edge \
--to=denys@ti.com \
--cc=meta-ti@yoctoproject.org \
--cc=sam.nelson@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.