From: Borislav Petkov <bp@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH] ftrace/x86: Fix function graph tracer reset path
Date: Mon, 16 May 2016 21:19:18 +0200 [thread overview]
Message-ID: <20160516191918.GC16265@pd.tnic> (raw)
In-Reply-To: <20160516151357.73fca76a@gandalf.local.home>
On Mon, May 16, 2016 at 03:13:57PM -0400, Steven Rostedt wrote:
> I actually thought about this first, but I thought it rather a hack
> (although one could argue all of function tracing is a hack ;-)
... I was about to say...
> But as the "weak" call was used to fix one location, why not use
> it here too. Being consistent, and also making sure all calls to
> ftrace_stub do the same.
Btw, arch_static_branch_jump() spells that 5-byte JMP too and not until
too long ago we had it in static_cpu_has()...
I guess after spending some time with the kernel, one can't really
differentiate hacks from proper design anymore. :-P
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-05-16 19:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 13:53 [PATCH] ftrace/x86: Fix function graph tracer reset path Namhyung Kim
2016-05-13 14:06 ` Steven Rostedt
2016-05-15 21:41 ` Matt Fleming
2016-05-15 0:41 ` Masami Hiramatsu
2016-05-15 13:06 ` Namhyung Kim
[not found] ` <20160516175614.53e0ceed3ec0880526fa1799@kernel.org>
2016-05-16 12:32 ` Namhyung Kim
2016-05-16 13:58 ` Steven Rostedt
2016-05-16 14:24 ` Namhyung Kim
2016-05-16 19:03 ` Borislav Petkov
2016-05-16 19:13 ` Steven Rostedt
2016-05-16 19:19 ` Borislav Petkov [this message]
2016-05-16 19:23 ` Steven Rostedt
2016-05-16 19:52 ` Matt Fleming
2016-05-16 22:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516191918.GC16265@pd.tnic \
--to=bp@suse.de \
--cc=hjl.tools@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.