From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Date: Tue, 17 May 2016 10:18:50 +0900 Message-ID: <20160517011850.GD31335@bbox> References: <1462760433-32357-1-git-send-email-minchan@kernel.org> <1462760433-32357-3-git-send-email-minchan@kernel.org> <20160516071751.GA32079@swordfish> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160516071751.GA32079@swordfish> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sergey Senozhatsky Cc: Rik van Riel , Sergey Senozhatsky , Rafael Aquini , Jonathan Corbet , Hugh Dickins , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, John Einar Reitan , linux-mm@kvack.org, Gioh Kim , Mel Gorman , Andrew Morton , Joonsoo Kim , Vlastimil Babka List-Id: virtualization@lists.linuxfoundation.org On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote: > On (05/09/16 11:20), Minchan Kim wrote: > [..] > > +++ b/include/linux/migrate.h > > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES]; > > > > #ifdef CONFIG_MIGRATION > > > > +extern int PageMovable(struct page *page); > > +extern void __SetPageMovable(struct page *page, struct address_space *mapping); > > +extern void __ClearPageMovable(struct page *page); > > extern void putback_movable_pages(struct list_head *l); > > extern int migrate_page(struct address_space *, > > struct page *, struct page *, enum migrate_mode); > > extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, > > unsigned long private, enum migrate_mode mode, int reason); > > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); > > +extern void putback_movable_page(struct page *page); > > > > extern int migrate_prep(void); > > extern int migrate_prep_local(void); > > given that some of Movable users can be built as modules, shouldn't > at least some of those symbols be exported via EXPORT_SYMBOL? Those functions aim for VM compaction so driver shouldn't use it. Only driver should be aware of are __SetPageMovable and __CleraPageMovable. I will export them. Thanks for the review, Sergey! > > -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by kanga.kvack.org (Postfix) with ESMTP id 03F706B0005 for ; Mon, 16 May 2016 21:18:50 -0400 (EDT) Received: by mail-ob0-f197.google.com with SMTP id aq1so2139518obc.2 for ; Mon, 16 May 2016 18:18:49 -0700 (PDT) Received: from lgeamrelo11.lge.com (LGEAMRELO11.lge.com. [156.147.23.51]) by mx.google.com with ESMTP id k5si584897igv.5.2016.05.16.18.18.48 for ; Mon, 16 May 2016 18:18:49 -0700 (PDT) Date: Tue, 17 May 2016 10:18:50 +0900 From: Minchan Kim Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Message-ID: <20160517011850.GD31335@bbox> References: <1462760433-32357-1-git-send-email-minchan@kernel.org> <1462760433-32357-3-git-send-email-minchan@kernel.org> <20160516071751.GA32079@swordfish> MIME-Version: 1.0 In-Reply-To: <20160516071751.GA32079@swordfish> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: owner-linux-mm@kvack.org List-ID: To: Sergey Senozhatsky Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Rik van Riel , Vlastimil Babka , Joonsoo Kim , Mel Gorman , Hugh Dickins , Rafael Aquini , virtualization@lists.linux-foundation.org, Jonathan Corbet , John Einar Reitan , dri-devel@lists.freedesktop.org, Sergey Senozhatsky , Gioh Kim On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote: > On (05/09/16 11:20), Minchan Kim wrote: > [..] > > +++ b/include/linux/migrate.h > > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES]; > > > > #ifdef CONFIG_MIGRATION > > > > +extern int PageMovable(struct page *page); > > +extern void __SetPageMovable(struct page *page, struct address_space *mapping); > > +extern void __ClearPageMovable(struct page *page); > > extern void putback_movable_pages(struct list_head *l); > > extern int migrate_page(struct address_space *, > > struct page *, struct page *, enum migrate_mode); > > extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, > > unsigned long private, enum migrate_mode mode, int reason); > > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); > > +extern void putback_movable_page(struct page *page); > > > > extern int migrate_prep(void); > > extern int migrate_prep_local(void); > > given that some of Movable users can be built as modules, shouldn't > at least some of those symbols be exported via EXPORT_SYMBOL? Those functions aim for VM compaction so driver shouldn't use it. Only driver should be aware of are __SetPageMovable and __CleraPageMovable. I will export them. Thanks for the review, Sergey! > > -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755154AbcEQBS5 (ORCPT ); Mon, 16 May 2016 21:18:57 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:45037 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755138AbcEQBSy (ORCPT ); Mon, 16 May 2016 21:18:54 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.98.203 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Tue, 17 May 2016 10:18:50 +0900 From: Minchan Kim To: Sergey Senozhatsky CC: Andrew Morton , , , Rik van Riel , Vlastimil Babka , Joonsoo Kim , Mel Gorman , Hugh Dickins , Rafael Aquini , , Jonathan Corbet , John Einar Reitan , , Sergey Senozhatsky , Gioh Kim Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page migration Message-ID: <20160517011850.GD31335@bbox> References: <1462760433-32357-1-git-send-email-minchan@kernel.org> <1462760433-32357-3-git-send-email-minchan@kernel.org> <20160516071751.GA32079@swordfish> MIME-Version: 1.0 In-Reply-To: <20160516071751.GA32079@swordfish> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/17 10:18:46, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/05/17 10:18:46, Serialize complete at 2016/05/17 10:18:46 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2016 at 04:17:51PM +0900, Sergey Senozhatsky wrote: > On (05/09/16 11:20), Minchan Kim wrote: > [..] > > +++ b/include/linux/migrate.h > > @@ -32,11 +32,16 @@ extern char *migrate_reason_names[MR_TYPES]; > > > > #ifdef CONFIG_MIGRATION > > > > +extern int PageMovable(struct page *page); > > +extern void __SetPageMovable(struct page *page, struct address_space *mapping); > > +extern void __ClearPageMovable(struct page *page); > > extern void putback_movable_pages(struct list_head *l); > > extern int migrate_page(struct address_space *, > > struct page *, struct page *, enum migrate_mode); > > extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, > > unsigned long private, enum migrate_mode mode, int reason); > > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); > > +extern void putback_movable_page(struct page *page); > > > > extern int migrate_prep(void); > > extern int migrate_prep_local(void); > > given that some of Movable users can be built as modules, shouldn't > at least some of those symbols be exported via EXPORT_SYMBOL? Those functions aim for VM compaction so driver shouldn't use it. Only driver should be aware of are __SetPageMovable and __CleraPageMovable. I will export them. Thanks for the review, Sergey! > > -ss