All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Ghadge <amitg.b14@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Date: Tue, 17 May 2016 09:31:56 +0530	[thread overview]
Message-ID: <20160517040036.GA9991@localhost.localdomain> (raw)
In-Reply-To: <20160517033455.GA30241@kroah.com>

Hello Greg KH,

I make patch same like other, I'm new and I nerver see changelog in other patches.

Where to add changelog? I followed you are tutorial.

Thanks,
Amit Ghadge
On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote:
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote:
> > I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,
> > 
> > drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> > 
> > This patch reduced the warning message.
> 
> Why didn't you put that information in the changelog area?
> 
> Please do so.
> 
> greg k-h

  reply	other threads:[~2016-05-17  4:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 17:34 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge
2016-05-16 18:19 ` Greg KH
2016-05-17  3:25   ` Amit Ghadge
2016-05-17  3:34     ` Greg KH
2016-05-17  4:01       ` Amit Ghadge [this message]
2016-05-17 13:47         ` Greg KH
2016-05-18  1:29           ` Amit Ghadge
2016-06-18  3:56 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517040036.GA9991@localhost.localdomain \
    --to=amitg.b14@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.