All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Wang Shilong <wangshilong1991@gmail.com>,
	linux-ext4@vger.kernel.org, adilger@dilger.ca,
	Shuichi Ihara <sihara@ddn.com>
Subject: Re: [PATCH] ext4: add lazyinit stats support
Date: Tue, 17 May 2016 00:45:07 -0400	[thread overview]
Message-ID: <20160517044507.GW7799@thunk.org> (raw)
In-Reply-To: <43a7d624-5fd1-a3a5-5f18-a84ebde86f1f@redhat.com>

On Mon, May 16, 2016 at 11:22:35PM -0500, Eric Sandeen wrote:
> 
> Sure thing; I'm still on the fence about usefulness, because if
> anyone really cares to wait for it to hit zero, they probably
> should have just changed their mkfs options to disable lazyinit.

Indeed, if you're going to stall your test startup until lazyinit is
done, it will be faster to let mke2fs initialize the inode table
blocks, since lazyinit deliberately rate limits how much I/O it sends
down to the disk in order to avoid impacting user latencies.  So i'd
recommend "mke2fs -E lazy_itable_init=0,lazy_journal_init=0" instead
of patching the kernel and then waiting for lazy itable init to
complete.  I think you'll be happier with how long this takes.

BTW, if you care about 99.9 percentile (long tail) latency as a
performance metric, it's a good idea to disable lazy inode table init
and just let mke2fs take its own sweet time.  This is what we do
inside Google, since we care very much about long tail latencies on a
number of our workloads.

Cheers,

						- Ted

  reply	other threads:[~2016-05-17  4:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  3:41 [PATCH] ext4: add lazyinit stats support Wang Shilong
2016-05-17  3:59 ` Eric Sandeen
2016-05-17  4:14   ` Wang Shilong
2016-05-17  4:22     ` Eric Sandeen
2016-05-17  4:45       ` Theodore Ts'o [this message]
2016-05-17  5:36         ` Shuichi Ihara
2016-05-17  6:13           ` Theodore Ts'o
2016-05-17  4:05 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517044507.GW7799@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=sihara@ddn.com \
    --cc=wangshilong1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.