From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Tue, 17 May 2016 11:24:27 +0100 Subject: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module In-Reply-To: <20160517095714.GA25167@sha-win-210.asiapac.arm.com> References: <1461783185-9056-1-git-send-email-dave.long@linaro.org> <1461783185-9056-11-git-send-email-dave.long@linaro.org> <20160517095714.GA25167@sha-win-210.asiapac.arm.com> Message-ID: <20160517102427.GD8104@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > +#ifdef CONFIG_ARM64 > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > I think you miss the KERN_INFO here. That's what pr_info() does over printk() - it adds the KERN_INFO more cleanly. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756002AbcEQKYs (ORCPT ); Tue, 17 May 2016 06:24:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:35118 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752097AbcEQKYq (ORCPT ); Tue, 17 May 2016 06:24:46 -0400 Date: Tue, 17 May 2016 11:24:27 +0100 From: Mark Brown To: Huang Shijie Cc: David Long , Catalin Marinas , Will Deacon , Sandeepa Prabhu , William Cohen , Pratyush Anand , Steve Capper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marc Zyngier , Mark Rutland , Petr Mladek , Viresh Kumar , John Blackwood , Feng Kan , Zi Shen Lim , Dave P Martin , Yang Shi , Vladimir Murzin , Kees Cook , "Suzuki K. Poulose" , Alex =?iso-8859-1?Q?Benn=E9e?= , Ard Biesheuvel , Greg Kroah-Hartman , Mark Salyzyn , James Morse , Christoffer Dall , Andrew Morton , Robin Murphy , Jens Wiklander , Balamurugan Shanmugam , nd@arm.com Message-ID: <20160517102427.GD8104@sirena.org.uk> References: <1461783185-9056-1-git-send-email-dave.long@linaro.org> <1461783185-9056-11-git-send-email-dave.long@linaro.org> <20160517095714.GA25167@sha-win-210.asiapac.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline In-Reply-To: <20160517095714.GA25167@sha-win-210.asiapac.arm.com> X-Cookie: FORCE YOURSELF TO RELAX! User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5p8PegU4iirBW1oA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > +#ifdef CONFIG_ARM64 > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > I think you miss the KERN_INFO here. That's what pr_info() does over printk() - it adds the KERN_INFO more cleanly. --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXOvFaAAoJECTWi3JdVIfQjUAH/1SfyhOpkne7xoZqsLj+UBoN LgjNyGqW5HpsK8JKdPRzQ+Ph9Byf9bxSGlXOI8mqFH8M6f0tGYojy34EskY5Isgm nQeVYGwkwf5GY5J8REJ33sA+UBPI79hZ0rXM0rvUrgGqGYlv7Lh/Nc41Dd4P7Kzk 0zWXXnEcc1BCS4dzt0/gb4Vt5JD4v8JHfynSyGRtymPBMWgdEYCpEBUl93mRCI6a pSw36RDlXPMKJtigEMcUBT3lf59f47P5xhvFXVEsWZ+7RhAEBKmpmmQp8mcTUFNm XZEHF+dvHqsuywBNvFI0e5YDtEBhiB/bKYsPoe/4+zyiWrL9qQg2mcAwFZxMBic= =Ll5Q -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA--