All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Chris Patterson <cjp256@gmail.com>
Cc: Kyle Temkin <ktemkin@binghamton.edu>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Dushyant K Behl <dushyantbehl@in.ibm.com>,
	Julien Grall <julien.grall@arm.com>,
	Meng Xu <xumengpanda@gmail.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Question about running Xen on NVIDIA Jetson-TK1
Date: Tue, 17 May 2016 14:47:44 -0400	[thread overview]
Message-ID: <20160517184744.GA6134@char.us.oracle.com> (raw)
In-Reply-To: <CABZSBQckj0Z6jrPkkMJogAcusibM7V=7_Ms+etVQxT+HUN7DbQ@mail.gmail.com>

On Tue, May 17, 2016 at 12:31:10PM -0400, Chris Patterson wrote:
> On Tue, May 17, 2016 at 9:37 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >> - The serial controller on the Tegra SoCs doesn't behave in the same
> >> was as most NS16550-compatibles; it actually adheres to the NS16550
> >> spec a little more rigidly than most compatible controllers. A
> >> coworker (Chris Patterson, cc'd) figured out what was going on; from
> >> what I understand, most 16550s generate the "transmit ready" interrupt
> >> once, when the device first can accept new FIFO entries. Both the
> >> original 16550 and the Tegra implementation generate the "transmit
> >> ready" interrupt /continuously/ when there's space available in the
> >> FIFO, slewing the CPU with a stream of constant interrupts.
> >
> > That may also be an issue on x86 I would think.
> >
> 
> On the x86 serial I have tested, it appears that the THRE interrupt
> goes low after the IIR read reset, and doesn't re-assert until
> UART_IER is flipped (or data is transmitted).  On the Tegra, the
> interrupt persists (or immediately re-asserts) after the IIR read
> reset.  I suppose this could be a problem on x86 if this behaviour
> exists in another uart.
> 
> > Is there some simple 16550 'fix' for this? As in reprogram it
> > to not be soo ready?
> 
> Yes, I do have a patch in my queue to address this. It simply
> implements the start_tx and stop_tx hooks and sets or masks
> UART_IER_ETHREI accordingly.  I believe this behaviour is consistent
> with the Linux kernel.  I have done some limited testing on it with
> both x86 and the Tegra (with additional patches for Tegra support) and
> things appear to work well. I can RFC it when our employer gives us
> approval.  Apologies for the delay.

Awesome! Looking forward to them and reviewing them!
> 
> Have a good day!
> -Chris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2016-05-17 18:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-15 19:35 Question about running Xen on NVIDIA Jetson-TK1 Meng Xu
2016-05-16 11:33 ` Julien Grall
2016-05-16 16:33   ` Meng Xu
2016-05-16 17:26     ` Konrad Rzeszutek Wilk
2016-05-16 17:30       ` Julien Grall
2016-05-16 17:33     ` Julien Grall
2016-05-16 19:39       ` Meng Xu
2016-05-16 23:27         ` Kyle Temkin
2016-05-17  3:27           ` Meng Xu
2016-05-17 13:37           ` Konrad Rzeszutek Wilk
2016-05-17 16:31             ` Chris Patterson
2016-05-17 18:47               ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160517184744.GA6134@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=cjp256@gmail.com \
    --cc=dushyantbehl@in.ibm.com \
    --cc=ijc@hellion.org.uk \
    --cc=julien.grall@arm.com \
    --cc=ktemkin@binghamton.edu \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xumengpanda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.