From: Minchan Kim <minchan@kernel.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
Rik van Riel <riel@redhat.com>, Michal Hocko <mhocko@kernel.org>,
Vinayak Menon <vinmenon@codeaurora.org>
Subject: Re: [PATCH] mm: make faultaround produce old ptes
Date: Wed, 18 May 2016 10:22:59 +0900 [thread overview]
Message-ID: <20160518012259.GA21490@bbox> (raw)
In-Reply-To: <1463488366-47723-1-git-send-email-kirill.shutemov@linux.intel.com>
On Tue, May 17, 2016 at 03:32:46PM +0300, Kirill A. Shutemov wrote:
> Currently, faultaround code produces young pte. This can screw up vmscan
> behaviour[1], as it makes vmscan think that these pages are hot and not
> push them out on first round.
>
> Let modify faultaround to produce old pte, so they can easily be
> reclaimed under memory pressure.
>
> This can to some extend defeat purpose of faultaround on machines
> without hardware accessed bit as it will not help up with reducing
> number of minor page faults.
>
> We may want to disable faultaround on such machines altogether, but
> that's subject for separate patchset.
>
> [1] https://lkml.kernel.org/r/1460992636-711-1-git-send-email-vinmenon@codeaurora.org
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Vinayak Menon <vinmenon@codeaurora.org>
> Cc: Minchan Kim <minchan@kernel.org>
I tested 512M mmap sequential word read test on non-HW access bit system
(i.e., ARM) and confirmed it doesn't increase minor fault any more.
= old =
minor fault: 131291
elapsed time: 6747645 usec
= new =
minor fault: 131291
elapsed time: 6709263 usec
0.56% benefit
Acked-by: Minchan Kim <minchan@kernel.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-18 1:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 12:32 [PATCH] mm: make faultaround produce old ptes Kirill A. Shutemov
2016-05-18 1:22 ` Minchan Kim [this message]
2016-05-18 1:27 ` Minchan Kim
2016-05-18 7:25 ` Michal Hocko
2016-05-18 8:04 ` Kirill A. Shutemov
2016-05-18 8:22 ` Michal Hocko
2016-05-18 8:33 ` Kirill A. Shutemov
2016-05-18 8:43 ` Michal Hocko
2016-05-19 4:27 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518012259.GA21490@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.