From: Carlos Maiolino <cmaiolino@redhat.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove spurious shutdown type check from xfs_bmap_finish()
Date: Wed, 18 May 2016 15:28:31 +0200 [thread overview]
Message-ID: <20160518132831.GA25154@redhat.com> (raw)
In-Reply-To: <1463573052-29336-1-git-send-email-bfoster@redhat.com>
On Wed, May 18, 2016 at 08:04:12AM -0400, Brian Foster wrote:
> The static checker reports that after commit 8d99fe92fed0 ("xfs: fix
> efi/efd error handling to avoid fs shutdown hangs"), the code has been
> reworked such that error == -EFSCORRUPTED is not possible in this
> codepath.
>
> Remove the spurious error check and just use SHUTDOWN_META_IO_ERROR
> unconditionally.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_bmap_util.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index 3246ebc..918a25a 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -132,9 +132,7 @@ xfs_bmap_finish(
> if (committed) {
> xfs_efi_release(efi);
> xfs_force_shutdown((*tp)->t_mountp,
> - (error == -EFSCORRUPTED) ?
> - SHUTDOWN_CORRUPT_INCORE :
> - SHUTDOWN_META_IO_ERROR);
> + SHUTDOWN_META_IO_ERROR);
> }
> return error;
> }
> --
> 2.4.11
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-05-18 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:04 [PATCH] xfs: remove spurious shutdown type check from xfs_bmap_finish() Brian Foster
2016-05-18 13:28 ` Carlos Maiolino [this message]
2016-05-23 14:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518132831.GA25154@redhat.com \
--to=cmaiolino@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.