From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] dma-buf/fence: add fence_collection fences Date: Thu, 19 May 2016 09:57:27 +0200 Message-ID: <20160519075726.GM27098@phenom.ffwll.local> References: <1463605193-18040-1-git-send-email-gustavo@padovan.org> <20160518225710.GA32627@nuc-i3427.alporthouse.com> <573D6F67.7070109@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37D846E930 for ; Thu, 19 May 2016 07:57:28 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id n129so18816015wmn.1 for ; Thu, 19 May 2016 00:57:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <573D6F67.7070109@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: marcheu@google.com, Daniel Stone , seanpaul@google.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, Daniel Vetter , Alex Deucher , Gustavo Padovan , John Harrison , m.chehab@samsung.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMTksIDIwMTYgYXQgMDk6NDY6NDdBTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAxOS4wNS4yMDE2IHVtIDAwOjU3IHNjaHJpZWIgQ2hyaXMgV2lsc29uOgo+ ID5PbiBXZWQsIE1heSAxOCwgMjAxNiBhdCAwNTo1OTo1MlBNIC0wMzAwLCBHdXN0YXZvIFBhZG92 YW4gd3JvdGU6Cj4gPj4rc3RhdGljIHZvaWQgY29sbGVjdGlvbl9jaGVja19jYl9mdW5jKHN0cnVj dCBmZW5jZSAqZmVuY2UsIHN0cnVjdCBmZW5jZV9jYiAqY2IpCj4gPj4rewo+ID4+KwlzdHJ1Y3Qg ZmVuY2VfY29sbGVjdGlvbl9jYiAqZl9jYjsKPiA+PisJc3RydWN0IGZlbmNlX2NvbGxlY3Rpb24g KmNvbGxlY3Rpb247Cj4gPj4rCj4gPj4rCWZfY2IgPSBjb250YWluZXJfb2YoY2IsIHN0cnVjdCBm ZW5jZV9jb2xsZWN0aW9uX2NiLCBjYik7Cj4gPj4rCWNvbGxlY3Rpb24gPSBmX2NiLT5jb2xsZWN0 aW9uOwo+ID4+Kwo+ID4+KwlpZiAoYXRvbWljX2RlY19hbmRfdGVzdCgmY29sbGVjdGlvbi0+bnVt X3BlbmRpbmdfZmVuY2VzKSkKPiA+PisJCWZlbmNlX3NpZ25hbCgmY29sbGVjdGlvbi0+YmFzZSk7 Cj4gPj4rfQo+ID4+Kwo+ID4+K3N0YXRpYyBib29sIGZlbmNlX2NvbGxlY3Rpb25fZW5hYmxlX3Np Z25hbGluZyhzdHJ1Y3QgZmVuY2UgKmZlbmNlKQo+ID4+K3sKPiA+PisJc3RydWN0IGZlbmNlX2Nv bGxlY3Rpb24gKmNvbGxlY3Rpb24gPSB0b19mZW5jZV9jb2xsZWN0aW9uKGZlbmNlKTsKPiA+PisJ aW50IGk7Cj4gPj4rCj4gPj4rCWZvciAoaSA9IDAgOyBpIDwgY29sbGVjdGlvbi0+bnVtX2ZlbmNl cyA7IGkrKykgewo+ID4+KwkJaWYgKGZlbmNlX2FkZF9jYWxsYmFjayhjb2xsZWN0aW9uLT5mZW5j ZXNbaV0uZmVuY2UsCj4gPj4rCQkJCSAgICAgICAmY29sbGVjdGlvbi0+ZmVuY2VzW2ldLmNiLAo+ ID4+KwkJCQkgICAgICAgY29sbGVjdGlvbl9jaGVja19jYl9mdW5jKSkgewo+ID4+KwkJCWF0b21p Y19kZWMoJmNvbGxlY3Rpb24tPm51bV9wZW5kaW5nX2ZlbmNlcyk7Cj4gPj4rCQl9Cj4gPj4rCX0K PiA+V2UgZG9uJ3QgYWx3YXlzIGhhdmUgYSBjb252ZW5pZW50IG1lYW5zIHRvIHByZWFsbG9jYXRl IGFuIGFycmF5IG9mCj4gPmZlbmNlcyB0byB1c2UuIEtlZXBpbmcgYSBsaXN0IG9mIGZlbmNlcyBp biBhZGRpdGlvbiB0byB0aGUgYXJyYXkgd291bGQKPiA+YmUgZWFzaWVyIHRvIHVzZXIgaW4gbWFu eSBjaXJjdW1zdGFuY2VzLgo+IAo+IEkgYWdyZWUgdGhhdCB0aGVyZSBpcyB1c2UgZm9yIHN1Y2gg YW4gaW1wbGVtZW50YXRpb24gYXMgd2VsbCwgYnV0IGFzCj4gbWVudGlvbmVkIGluIHRoZSBsYXN0 IHJldmlldyBjeWNsZSB3ZSBpbnRlbnRpb25hbGx5IGNob3NlIGFuIGFycmF5IGluc3RlYWQKPiBv ZiBhIG1vcmUgY29tcGxleCBpbXBsZW1lbnRhdGlvbiBoZXJlLgo+IAo+IFRoaXMgd2F5IHRoZSBh cnJheSBjYW4gYmUgcGFzc2VkIHRvIGZ1bmN0aW9uIGxpa2UgZmVuY2Vfd2FpdF9hbnlfdGltZW91 dCgpCj4gYXMgd2VsbC4KCisxIG9uIGZlbmNlX2FycmF5LgoKPiBJIGFsc28gc3VnZ2VzdGVkIHRv IHJlbmFtZSBpdCB0byBmZW5jZV9hcnJheSB0byBtYWtlIHRoYXQgZGlmZmVyZW5jZSBjbGVhcgo+ IGFuZCBhbGxvdyBmb3IgYW5vdGhlciBpbXBsZW1lbnRhdGlvbiB0byBsaXZlIHNpZGUgYnkgc2lk ZSB3aXRoIHRoaXMuCj4gCj4gTXkgY3J1eCBhdCB0aGUgbW9tZW50IGlzIHRoYXQgSSBuZWVkIGJv dGggZm9yIHRoZSBhbWRncHUgZHJpdmVyLCBhbiBhcnJheQo+IGJhc2VkIGltcGxlbWVudGF0aW9u IGFuZCBhIGNvbGxlY3Rpb24gbGlrZSBvbmUuCj4gCj4gR3VzdGF2byB3b3VsZCB5b3UgbWluZCBp ZiBJIHRha2UgeW91ciBwYXRjaGVzIGFuZCB3b3JrIGEgYml0IG9uIHRoaXM/CgpJIHRoaW5rIHRo ZSBnb2FsIGlzIHRvIHN0YXJ0IGxhbmRpbmcgdGhlIGF0b21pYyBmZW5jZSBzdHVmZiBpbiA0Ljgu ClByb2JhYmx5IHNpbXBsZXN0IGlmIHdlIGNvbnZlcmdlIG9uIGEgZmlyc3QgaXRlcmF0aW9uIHRo YXQgSSBjYW4gcHVsbCBpbnRvCmRybS1taXNjIHJpZ2h0IGFmdGVyIDQuNy1yYzEuIFRoZW4geW91 IGNhbiBib3RoIGJhc2UgeW91ciByZXNwZWN0aXZlIHdvcmsKb24gdG9wIG9mIHRoYXQgYnJhbmNo IChpdCdzIGEgc3RhYmxlIG9uZSwgc28gY2FuIGV2ZW4gYmFzZSBvZmZpY2lhbApicmFuY2hlcyBv biBpdCkuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbcESH53 (ORCPT ); Thu, 19 May 2016 03:57:29 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33073 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbcESH52 (ORCPT ); Thu, 19 May 2016 03:57:28 -0400 Date: Thu, 19 May 2016 09:57:27 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Chris Wilson , Gustavo Padovan , dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Alex Deucher , Gustavo Padovan , John Harrison , m.chehab@samsung.com Subject: Re: [PATCH 1/2] dma-buf/fence: add fence_collection fences Message-ID: <20160519075726.GM27098@phenom.ffwll.local> Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , Chris Wilson , Gustavo Padovan , dri-devel@lists.freedesktop.org, marcheu@google.com, Daniel Stone , seanpaul@google.com, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Alex Deucher , Gustavo Padovan , John Harrison , m.chehab@samsung.com References: <1463605193-18040-1-git-send-email-gustavo@padovan.org> <20160518225710.GA32627@nuc-i3427.alporthouse.com> <573D6F67.7070109@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <573D6F67.7070109@amd.com> X-Operating-System: Linux phenom 4.6.0-rc5+ User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 09:46:47AM +0200, Christian König wrote: > Am 19.05.2016 um 00:57 schrieb Chris Wilson: > >On Wed, May 18, 2016 at 05:59:52PM -0300, Gustavo Padovan wrote: > >>+static void collection_check_cb_func(struct fence *fence, struct fence_cb *cb) > >>+{ > >>+ struct fence_collection_cb *f_cb; > >>+ struct fence_collection *collection; > >>+ > >>+ f_cb = container_of(cb, struct fence_collection_cb, cb); > >>+ collection = f_cb->collection; > >>+ > >>+ if (atomic_dec_and_test(&collection->num_pending_fences)) > >>+ fence_signal(&collection->base); > >>+} > >>+ > >>+static bool fence_collection_enable_signaling(struct fence *fence) > >>+{ > >>+ struct fence_collection *collection = to_fence_collection(fence); > >>+ int i; > >>+ > >>+ for (i = 0 ; i < collection->num_fences ; i++) { > >>+ if (fence_add_callback(collection->fences[i].fence, > >>+ &collection->fences[i].cb, > >>+ collection_check_cb_func)) { > >>+ atomic_dec(&collection->num_pending_fences); > >>+ } > >>+ } > >We don't always have a convenient means to preallocate an array of > >fences to use. Keeping a list of fences in addition to the array would > >be easier to user in many circumstances. > > I agree that there is use for such an implementation as well, but as > mentioned in the last review cycle we intentionally chose an array instead > of a more complex implementation here. > > This way the array can be passed to function like fence_wait_any_timeout() > as well. +1 on fence_array. > I also suggested to rename it to fence_array to make that difference clear > and allow for another implementation to live side by side with this. > > My crux at the moment is that I need both for the amdgpu driver, an array > based implementation and a collection like one. > > Gustavo would you mind if I take your patches and work a bit on this? I think the goal is to start landing the atomic fence stuff in 4.8. Probably simplest if we converge on a first iteration that I can pull into drm-misc right after 4.7-rc1. Then you can both base your respective work on top of that branch (it's a stable one, so can even base official branches on it). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch