From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Thu, 19 May 2016 09:01:39 +0000 Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid Message-Id: <20160519090139.GA1539@amd> List-Id: References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Scot Doyle Cc: Jonathan Liu , Peter Hurley , David Daney , Jean-Philippe Brucker , Dann Frazier , Ming Lei , Jiri Slaby , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, "Chintakuntla, Radha" , Tomi Valkeinen , stable@vger.kernel.org, ddaney.cavm@gmail.com, Alistair Popple , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org Hi! > Two current [1] and three previous [2] systems locked during boot > because the cursor flash timer was set using an ops->cur_blink_jiffies > value of 0. Previous patches attempted to solve the problem by moving > variable initialization earlier in the setup sequence [2]. > > Use the normal cursor blink default interval of 200 ms if > ops->cur_blink_jiffies is not in the range specified in commit > bd63364caa8d. Since invalid values are not used, specific system > initialization timings should not cause lockups. > > [1] https://bugs.launchpad.net/bugs/1574814 > [2] see commits: 2a17d7e80f1d, f235f664a8af, a1e533ec07d5 Acked-by: Pavel Machek > static void cursor_timer_handler(unsigned long dev_addr) > { > struct fb_info *info = (struct fb_info *) dev_addr; > struct fbcon_ops *ops = info->fbcon_par; > > queue_work(system_power_efficient_wq, &info->queue); > - mod_timer(&ops->cursor_timer, jiffies + ops->cur_blink_jiffies); > + mod_timer(&ops->cursor_timer, jiffies + > + cursor_blink_jiffies(ops->cur_blink_jiffies)); > } > > static void fbcon_add_cursor_timer(struct fb_info *info) And actually... perhaps mod_timer should have some check for too low timeouts..? WARN_ON? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid Date: Thu, 19 May 2016 11:01:39 +0200 Message-ID: <20160519090139.GA1539@amd> References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id A1D076E26F for ; Thu, 19 May 2016 09:01:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Scot Doyle Cc: Jonathan Liu , Peter Hurley , David Daney , Jean-Philippe Brucker , Dann Frazier , Ming Lei , Jiri Slaby , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, "Chintakuntla, Radha" , Tomi Valkeinen , stable@vger.kernel.org, ddaney.cavm@gmail.com, Alistair Popple , Jean-Christophe Plagniol-Villard , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkhCgo+IFR3byBjdXJyZW50IFsxXSBhbmQgdGhyZWUgcHJldmlvdXMgWzJdIHN5c3RlbXMgbG9j a2VkIGR1cmluZyBib290Cj4gYmVjYXVzZSB0aGUgY3Vyc29yIGZsYXNoIHRpbWVyIHdhcyBzZXQg dXNpbmcgYW4gb3BzLT5jdXJfYmxpbmtfamlmZmllcwo+IHZhbHVlIG9mIDAuIFByZXZpb3VzIHBh dGNoZXMgYXR0ZW1wdGVkIHRvIHNvbHZlIHRoZSBwcm9ibGVtIGJ5IG1vdmluZwo+IHZhcmlhYmxl IGluaXRpYWxpemF0aW9uIGVhcmxpZXIgaW4gdGhlIHNldHVwIHNlcXVlbmNlIFsyXS4KPiAKPiBV c2UgdGhlIG5vcm1hbCBjdXJzb3IgYmxpbmsgZGVmYXVsdCBpbnRlcnZhbCBvZiAyMDAgbXMgaWYK PiBvcHMtPmN1cl9ibGlua19qaWZmaWVzIGlzIG5vdCBpbiB0aGUgcmFuZ2Ugc3BlY2lmaWVkIGlu IGNvbW1pdAo+IGJkNjMzNjRjYWE4ZC4gU2luY2UgaW52YWxpZCB2YWx1ZXMgYXJlIG5vdCB1c2Vk LCBzcGVjaWZpYyBzeXN0ZW0KPiBpbml0aWFsaXphdGlvbiB0aW1pbmdzIHNob3VsZCBub3QgY2F1 c2UgbG9ja3Vwcy4KPiAKPiBbMV0gaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvYnVncy8xNTc0 ODE0Cj4gWzJdIHNlZSBjb21taXRzOiAyYTE3ZDdlODBmMWQsIGYyMzVmNjY0YThhZiwgYTFlNTMz ZWMwN2Q1CgpBY2tlZC1ieTogUGF2ZWwgTWFjaGVrIDxwYXZlbEB1Y3cuY3o+Cgo+ICBzdGF0aWMg dm9pZCBjdXJzb3JfdGltZXJfaGFuZGxlcih1bnNpZ25lZCBsb25nIGRldl9hZGRyKQo+ICB7Cj4g IAlzdHJ1Y3QgZmJfaW5mbyAqaW5mbyA9IChzdHJ1Y3QgZmJfaW5mbyAqKSBkZXZfYWRkcjsKPiAg CXN0cnVjdCBmYmNvbl9vcHMgKm9wcyA9IGluZm8tPmZiY29uX3BhcjsKPiAgCj4gIAlxdWV1ZV93 b3JrKHN5c3RlbV9wb3dlcl9lZmZpY2llbnRfd3EsICZpbmZvLT5xdWV1ZSk7Cj4gLQltb2RfdGlt ZXIoJm9wcy0+Y3Vyc29yX3RpbWVyLCBqaWZmaWVzICsgb3BzLT5jdXJfYmxpbmtfamlmZmllcyk7 Cj4gKwltb2RfdGltZXIoJm9wcy0+Y3Vyc29yX3RpbWVyLCBqaWZmaWVzICsKPiArCSAgICBjdXJz b3JfYmxpbmtfamlmZmllcyhvcHMtPmN1cl9ibGlua19qaWZmaWVzKSk7Cj4gIH0KPiAgCj4gIHN0 YXRpYyB2b2lkIGZiY29uX2FkZF9jdXJzb3JfdGltZXIoc3RydWN0IGZiX2luZm8gKmluZm8pCgpB bmQgYWN0dWFsbHkuLi4gcGVyaGFwcyBtb2RfdGltZXIgc2hvdWxkIGhhdmUgc29tZSBjaGVjayBm b3IgdG9vIGxvdwp0aW1lb3V0cy4uPwoKV0FSTl9PTj8KCQkJCQkJCQkJUGF2ZWwKCi0tIAooZW5n bGlzaCkgaHR0cDovL3d3dy5saXZlam91cm5hbC5jb20vfnBhdmVsbWFjaGVrCihjZXNreSwgcGlj dHVyZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmkuY3ovfnBhdmVsL3BpY3R1cmUvaG9y c2VzL2Jsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754119AbcESJBp (ORCPT ); Thu, 19 May 2016 05:01:45 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48033 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbcESJBn (ORCPT ); Thu, 19 May 2016 05:01:43 -0400 Date: Thu, 19 May 2016 11:01:39 +0200 From: Pavel Machek To: Scot Doyle Cc: Tomi Valkeinen , Jean-Christophe Plagniol-Villard , David Daney , Ming Lei , Dann Frazier , Peter Hurley , Jonathan Liu , Alistair Popple , Jean-Philippe Brucker , "Chintakuntla, Radha" , Greg Kroah-Hartman , Jiri Slaby , David Airlie , ddaney.cavm@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] fbcon: use default if cursor blink interval is not valid Message-ID: <20160519090139.GA1539@amd> References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com> <20160517204912.GA29719@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > Two current [1] and three previous [2] systems locked during boot > because the cursor flash timer was set using an ops->cur_blink_jiffies > value of 0. Previous patches attempted to solve the problem by moving > variable initialization earlier in the setup sequence [2]. > > Use the normal cursor blink default interval of 200 ms if > ops->cur_blink_jiffies is not in the range specified in commit > bd63364caa8d. Since invalid values are not used, specific system > initialization timings should not cause lockups. > > [1] https://bugs.launchpad.net/bugs/1574814 > [2] see commits: 2a17d7e80f1d, f235f664a8af, a1e533ec07d5 Acked-by: Pavel Machek > static void cursor_timer_handler(unsigned long dev_addr) > { > struct fb_info *info = (struct fb_info *) dev_addr; > struct fbcon_ops *ops = info->fbcon_par; > > queue_work(system_power_efficient_wq, &info->queue); > - mod_timer(&ops->cursor_timer, jiffies + ops->cur_blink_jiffies); > + mod_timer(&ops->cursor_timer, jiffies + > + cursor_blink_jiffies(ops->cur_blink_jiffies)); > } > > static void fbcon_add_cursor_timer(struct fb_info *info) And actually... perhaps mod_timer should have some check for too low timeouts..? WARN_ON? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html