From: Damien Lespiau <damien.lespiau@intel.com>
To: Ben Widawsky <benjamin.widawsky@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc.
Date: Thu, 19 May 2016 15:07:46 +0100 [thread overview]
Message-ID: <20160519140746.GC28509@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20160519140237.GA21272@intel.com>
On Thu, May 19, 2016 at 07:02:40AM -0700, Ben Widawsky wrote:
> On Thu, May 19, 2016 at 12:28:10PM +0100, Damien Lespiau wrote:
> > On Mon, May 16, 2016 at 01:39:10PM +0300, Marius Vlad wrote:
> > > Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> > > ---
> > > assembler/gram.y | 74 ++++++++++++++++++++++++++++----------------------------
> > > 1 file changed, 37 insertions(+), 37 deletions(-)
> >
> > The only way to test the change is to regenerate the vaapi shaders from
> > source and check for differences in the generated opcodes.
>
> Didn't we have something like this in the test/ directory?
We have just a few unmaintained tests that don't pass (or do they?) and
they barely scratch the surface of what would be needed to decent
coverage.
vaapi-driver is a much better test suite.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-19 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 10:39 [PATCH i-g-t] assembler/: Fix lex warnings for %empty and %nonassoc Marius Vlad
2016-05-19 11:28 ` Damien Lespiau
2016-05-19 14:02 ` Ben Widawsky
2016-05-19 14:07 ` Damien Lespiau [this message]
2016-06-23 11:21 ` Marius Vlad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519140746.GC28509@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.