From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
Cc: ego@linux.vnet.ibm.com, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, paulus@ozlabs.org,
linux-kernel@vger.kernel.org, mikey@neuling.org
Subject: Re: [PATCH v2 2/9] powerpc/kvm: make hypervisor state restore a function
Date: Thu, 19 May 2016 19:54:56 +0530 [thread overview]
Message-ID: <20160519142456.GA913@in.ibm.com> (raw)
In-Reply-To: <573C14CC.20307@linux.vnet.ibm.com>
Hi Shreyas,
On Wed, May 18, 2016 at 12:37:56PM +0530, Shreyas B Prabhu wrote:
[..snip..]
> >> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S
> >> index 7716ceb..7ebfbb0 100644
> >> --- a/arch/powerpc/kernel/exceptions-64s.S
> >> +++ b/arch/powerpc/kernel/exceptions-64s.S
> >> @@ -107,25 +107,8 @@ BEGIN_FTR_SECTION
> >> beq 9f
> >>
> >> cmpwi cr3,r13,2
> >> + bl power7_restore_hyp_resource
> >>
> >> - /*
> >> - * Check if last bit of HSPGR0 is set. This indicates whether we are
> >> - * waking up from winkle.
> >> - */
> >> - GET_PACA(r13)
> >> - clrldi r5,r13,63
> >> - clrrdi r13,r13,1
> >> - cmpwi cr4,r5,1
> >> - mtspr SPRN_HSPRG0,r13
> >> -
> >> - lbz r0,PACA_THREAD_IDLE_STATE(r13)
> >> - cmpwi cr2,r0,PNV_THREAD_NAP
> >> - bgt cr2,8f /* Either sleep or Winkle */
> >> -
> >> - /* Waking up from nap should not cause hypervisor state loss */
> >> - bgt cr3,.
> >> -
> >> - /* Waking up from nap */
> >> li r0,PNV_THREAD_RUNNING
> >> stb r0,PACA_THREAD_IDLE_STATE(r13) /* Clear thread state */
> >>
> >> @@ -143,13 +126,9 @@ BEGIN_FTR_SECTION
> >>
> >> /* Return SRR1 from power7_nap() */
> >> mfspr r3,SPRN_SRR1
> >> - beq cr3,2f
> >> - b power7_wakeup_noloss
> >> -2: b power7_wakeup_loss
> >> -
> >> - /* Fast Sleep wakeup on PowerNV */
> >> -8: GET_PACA(r13)
> >
> > In the old code, we do a GET_PACA(r13) before invoking the
> > power7_wakeup_tb_loss. In the new code we don't. Can you explain
> > this omission ?
>
> GET_PACA(13) is the called in the beginning of
> power7_restore_hyp_resource. So r13 contains pointer to PACA when
> power7_wakeup_tb_loss invoked later in the same function.
Ah, I see it now. So the GET_PACA(r13) at 8: was anyway redundant in
the older code.
You can add my Reviewed-by: to this patch.
--
Thanks and Regards
gautham.
next prev parent reply other threads:[~2016-05-19 14:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 8:24 [PATCH v2 0/9] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-03 8:24 ` [PATCH v2 1/9] powerpc/powernv: Move CHECK_HMI_INTERRUPT to exception-64s header Shreyas B. Prabhu
2016-05-18 4:35 ` Gautham R Shenoy
2016-05-18 7:21 ` Shreyas B Prabhu
2016-05-03 8:24 ` [PATCH v2 2/9] powerpc/kvm: make hypervisor state restore a function Shreyas B. Prabhu
2016-05-18 6:25 ` Gautham R Shenoy
2016-05-18 7:07 ` Shreyas B Prabhu
2016-05-19 14:24 ` Gautham R Shenoy [this message]
2016-05-20 1:45 ` Paul Mackerras
2016-05-03 8:24 ` [PATCH v2 3/9] powerpc/powernv: Move idle code usable by multiple hardware to common location Shreyas B. Prabhu
2016-05-18 6:29 ` Gautham R Shenoy
2016-05-03 8:24 ` [PATCH v2 4/9] powerpc/powernv: Make power7_powersave_common more generic Shreyas B. Prabhu
2016-05-18 6:37 ` Gautham R Shenoy
2016-05-18 6:51 ` Shreyas B Prabhu
2016-05-19 14:26 ` Gautham R Shenoy
2016-05-03 8:24 ` [PATCH v2 5/9] powerpc/powernv: Move idle related macros to cpuidle.h Shreyas B. Prabhu
2016-05-19 14:27 ` Gautham R Shenoy
2016-05-03 8:24 ` [PATCH v2 6/9] powerpc/powernv: set power_save func after the idle states are initialized Shreyas B. Prabhu
2016-05-18 6:45 ` Gautham R Shenoy
2016-05-03 8:24 ` [PATCH v2 7/9] powerpc/powernv: Add platform support for stop instruction Shreyas B. Prabhu
2016-05-18 17:57 ` Gautham R Shenoy
2016-05-20 5:25 ` Paul Mackerras
2016-05-20 6:16 ` Shreyas B Prabhu
2016-05-20 6:16 ` Shreyas B Prabhu
2016-05-03 8:24 ` [PATCH v2 8/9] cpuidle/powernv: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-05-03 8:24 ` [PATCH v2 9/9] powerpc/powernv: Use deepest stop state when cpu is offlined Shreyas B. Prabhu
2016-05-18 18:07 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519142456.GA913@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.