From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: migor-ts - fix error for modular build
Date: Thu, 19 May 2016 09:34:35 -0700 [thread overview]
Message-ID: <20160519163435.GE38800@dtor-ws> (raw)
In-Reply-To: <1463502759-14393-2-git-send-email-javier@osg.samsung.com>
On Tue, May 17, 2016 at 12:32:38PM -0400, Javier Martinez Canillas wrote:
> There is a typo in the driver for the I2C device table that is passed to
> the MODULE_DEVICE_TABLE() macro, this leads to the following build error:
>
> CC [M] drivers/input/touchscreen//migor_ts.o
> drivers/input/touchscreen//migor_ts.c:233:21: error: 'migor_ts' undeclared here (not in a function)
> MODULE_DEVICE_TABLE(i2c, migor_ts);
> ^
> drivers/input/touchscreen//migor_ts.c:233:31: error: '__mod_i2c__migor_ts_device_table' aliased to undefined symbol 'migor_ts'
> MODULE_DEVICE_TABLE(i2c, migor_ts);
> ^
> scripts/Makefile.build:295: recipe for target 'drivers/input/touchscreen//migor_ts.o' failed
> make[1]: *** [drivers/input/touchscreen//migor_ts.o] Error 1
> Makefile:1446: recipe for target '_module_drivers/input/touchscreen/' failed
> make: *** [_module_drivers/input/touchscreen/] Error 2
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
>
> ---
>
> drivers/input/touchscreen/migor_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/migor_ts.c b/drivers/input/touchscreen/migor_ts.c
> index c038db93e2c3..e4b92c4cae3b 100644
> --- a/drivers/input/touchscreen/migor_ts.c
> +++ b/drivers/input/touchscreen/migor_ts.c
> @@ -230,7 +230,7 @@ static const struct i2c_device_id migor_ts_id[] = {
> { "migor_ts", 0 },
> { }
> };
> -MODULE_DEVICE_TABLE(i2c, migor_ts);
> +MODULE_DEVICE_TABLE(i2c, migor_ts_id);
>
> static struct i2c_driver migor_ts_driver = {
> .driver = {
> --
> 2.5.5
>
--
Dmitry
next prev parent reply other threads:[~2016-05-19 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 16:32 [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled Javier Martinez Canillas
2016-05-17 16:32 ` [PATCH 2/2] Input: migor-ts - fix error for modular build Javier Martinez Canillas
2016-05-19 16:34 ` Dmitry Torokhov [this message]
2016-05-19 16:34 ` [PATCH 1/2] Input: migor-ts - allow driver to build if COMPILE_TEST is enabled Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519163435.GE38800@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.