From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 2/6] batman-adv: speed up dat by snooping received ip traffic
Date: Thu, 19 May 2016 21:45:53 +0200 [thread overview]
Message-ID: <20160519194553.GD12565@otheros> (raw)
In-Reply-To: <1462525107-19750-3-git-send-email-apape@phoenixcontact.com>
On Fri, May 06, 2016 at 10:58:23AM +0200, Andreas Pape wrote:
> +void batadv_dat_entry_check(struct batadv_priv *bat_priv, struct sk_buff *skb,
> + unsigned short vid)
> +{
[...]
> + if (iphdr) {
> + batadv_dbg(BATADV_DBG_DAT, bat_priv,
> + "Snooped IP address: %pI4 %pM (vid: %d)\n",
> + &iphdr->saddr, ethhdr->h_source,
> + BATADV_PRINT_VID(vid));
> + batadv_dat_entry_add(bat_priv, iphdr->saddr,
> + ethhdr->h_source, vid);
> + }
Not sure whether it is necessary, or whether there is a check
somewhere later within DAT. But should we exclude some
iphdr->saddr or ethhdr->h_source addresses? For instance a
DHCPDISCOVER usually has a zero-ip address.
next prev parent reply other threads:[~2016-05-19 19:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 8:58 [B.A.T.M.A.N.] [PATCHv3 0/6] batman-adv: Optimizations for setups running dat and bla Andreas Pape
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 1/6] batman-adv: prevent multiple ARP replies sent by gateways if dat enbled Andreas Pape
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 2/6] batman-adv: speed up dat by snooping received ip traffic Andreas Pape
2016-05-06 9:53 ` Sven Eckelmann
2016-05-06 10:03 ` Sven Eckelmann
2016-05-19 19:33 ` Linus Lüssing
2016-05-19 22:22 ` Linus Lüssing
2016-05-19 19:45 ` Linus Lüssing [this message]
2016-05-19 20:30 ` Linus Lüssing
2016-05-19 22:48 ` Linus Lüssing
2016-05-19 23:11 ` Linus Lüssing
2016-05-20 11:32 ` [B.A.T.M.A.N.] Antwort: " Andreas Pape
2016-05-20 12:56 ` Antonio Quartulli
2016-05-20 13:51 ` [B.A.T.M.A.N.] " Antonio Quartulli
2016-06-13 13:45 ` Andreas Pape
2016-06-23 20:34 ` Linus Lüssing
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 3/6] batman-adv: prevent duplication of ARP replies when DAT is used Andreas Pape
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 4/6] batman-adv: drop unicast packets from other backbone gw Andreas Pape
2016-05-06 10:43 ` Sven Eckelmann
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 5/6] batman-adv: changed debug messages for easier bla debugging Andreas Pape
2016-05-06 8:58 ` [B.A.T.M.A.N.] [PATCHv3 6/6] batman-adv: handle race condition for claims between gateways Andreas Pape
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519194553.GD12565@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.