From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 19 May 2016 14:10:15 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Mike Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: fix critical clock locking Message-ID: <20160519211015.GQ3492@codeaurora.org> References: <1463126431-29071-1-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1463126431-29071-1-git-send-email-maxime.ripard@free-electrons.com> List-ID: On 05/13, Maxime Ripard wrote: > The critical clock handling in __clk_core_init isn't taking the enable lock > before calling clk_core_enable, which in turns triggers the warning in the > lockdep_assert_held call in that function when lockep is enabled. > > Add the calls to clk_enable_lock/unlock to make sure it doesn't happen. > > Fixes: 32b9b1096186 ("clk: Allow clocks to be marked as CRITICAL") > Signed-off-by: Maxime Ripard > > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project