Re: [PATCH v2 1/2] ASoC: wm8985: add device tree binding for WM8985

[Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>]

On Tue, May 17, 2016 at 02:49:48PM +0200, Petr Kulhavy wrote:
> Add device tree binding for the WM8985 codec driver.
> 
> Signed-off-by: Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> v1: initial
> v2: no change
> 
>  Documentation/devicetree/bindings/sound/wm8985.txt | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wm8985.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/wm8985.txt b/Documentation/devicetree/bindings/sound/wm8985.txt
> new file mode 100644
> index 000000000000..788d64766257
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wm8985.txt
> @@ -0,0 +1,36 @@
> +Wolfson Microelectronics WM8985 and WM8758 audio codecs
> +
> +These devices support both I2C and SPI (configured with pin strapping
> +on the board).
> +
> +Required properties:
> +
> +  - compatible : "wlf,wm8985" or "wlf,wm8758"
> +
> +  - reg : the I2C address of the device for I2C, the chip select
> +          number for SPI.
> +
> +Pins on the device for linking into audio routes:
> +
> +  * LIN      : left microphone pre-amp negative input
> +  * LIP      : left microphone pre-amp positive input
> +  * RIN      : right microphone pre-amp negative input
> +  * RIP      : right microphone pre-amp positive input
> +  * L2       : left line input / secondary pre-amp positive input
> +  * R2       : right line input / secondary pre-amp positive input
> +  * AUXL     : left auxiliary input (WM8985 only)
> +  * AUXR     : right auxiliary input (WM8985 only)
> +
> +  * HPL      : left headphone / line output (the LOUT1 pin)
> +  * HPR      : right headphone / line output (the ROUT1 pin)
> +  * SPKL     : left headphone / line output (the LOUT2 pin)
> +  * SPKR     : right headphone / line output (the ROUT2 pin)
> +  * Mic Bias : microphone bias
> +
> +
> +Example:
> +
> +wm8758: audio-codec@1a {
> +	compatible = "wlf,wm8758";
> +	reg = <0x1a>;
> +};

You should probably mention the regulators as well.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html