From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
rientjes@google.com, linux-mm@kvack.org
Subject: Re: [PATCH v3] mm,oom: speed up select_bad_process() loop.
Date: Sat, 21 May 2016 00:04:33 +0200 [thread overview]
Message-ID: <20160520220432.GA22324@redhat.com> (raw)
In-Reply-To: <20160520064244.GD19172@dhcp22.suse.cz>
On 05/20, Michal Hocko wrote:
>
> On Fri 20-05-16 03:50:01, Oleg Nesterov wrote:
> > On 05/19, Michal Hocko wrote:
> > >
> > > Long term I
> > > would like to to move this logic into the mm_struct, it would be just
> > > larger surgery I guess.
> >
> > Why we can't do this right now? Just another MMF_ flag set only once and
> > never cleared.
>
> It is more complicated and so more error prone.
Sure, but don't we want this anyway in the long term?
> We have to sort out
> shortcuts which get TIF_MEMDIE without killing first.
Yes, but this seems a bit "off-topic" to me... but probably I do not understand
the problem enough.
> And we have that
> nasty "mm shared between independant processes" case there.
Yes, yes, please see another email.
> If you feel that this step is not really worth it
No, no. Unless I see something which looks "obviously wrong" to me, I won't argue
with this (or any other) change as long as you and Tetsuo agree on it.
I understand that it is veru easy to blame OOM-killer (and the changes in this
area), but it is not easy to fix this code ;)
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-05-20 22:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:20 [PATCH v2] mm,oom: speed up select_bad_process() loop Tetsuo Handa
2016-05-18 12:51 ` Michal Hocko
2016-05-18 13:30 ` [PATCH v3] " Tetsuo Handa
2016-05-18 14:15 ` Michal Hocko
2016-05-18 21:09 ` Andrew Morton
2016-05-19 6:53 ` Michal Hocko
2016-05-19 7:17 ` Michal Hocko
2016-05-19 8:17 ` Michal Hocko
2016-05-20 1:50 ` Oleg Nesterov
2016-05-20 2:13 ` Oleg Nesterov
2016-05-20 6:42 ` Michal Hocko
2016-05-20 22:04 ` Oleg Nesterov [this message]
2016-05-18 14:44 ` Tetsuo Handa
2016-05-20 7:50 ` Michal Hocko
2016-05-20 11:51 ` Tetsuo Handa
2016-05-20 12:09 ` Michal Hocko
2016-05-20 13:41 ` Tetsuo Handa
2016-05-20 13:44 ` Tetsuo Handa
2016-05-20 15:23 ` Michal Hocko
2016-05-20 15:56 ` Tetsuo Handa
2016-05-23 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520220432.GA22324@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.