All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf stat: Print topology/time headers with --metric-only
Date: Sat, 21 May 2016 13:17:03 +0200	[thread overview]
Message-ID: <20160521111703.GA5761@krava> (raw)
In-Reply-To: <1463773815-25984-1-git-send-email-andi@firstfloor.org>

On Fri, May 20, 2016 at 12:50:14PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When --metric-only is enabled there were no headers for the topology
> in interval mode.  Also when headers were printed they were
> on a separate line.
> 
> Before:
> 
> $ perf stat  --metric-only  -A -I 1000 -a
>      1.001038376       frontend cycles idle insn per cycle       stalled cycles per insn branch-misses of all branches
>      1.001038376 CPU0     123.54%               0.23                5.29                    7.61%
>      1.001038376 CPU1     137.78%               0.24                5.13                   10.07%
>      1.001038376 CPU2      64.48%               0.22                5.50                    6.84%
> 
> After:
> 
> $ perf stat  --metric-only  -A -I 1000 -a
>      1.001111114 CPU0      82.46%               0.32                2.60                    7.64%
>      1.001111114 CPU1     126.63%               0.02               42.83                    0.15%
>      1.001111114 CPU2     193.54%               0.32                2.59                    6.92%
> 
> v2: Move all headers on a single line

changelog is wrong

[jolsa@ibm-x3650m4-01 perf]$ sudo ./perf stat  --metric-only  -A -I 1000 -a
#           time CPU frontend cycles idle backend cycles idle  insn per cycle       stalled cycles per insn branch-misses of all branches 
     1.003232468 CPU0      69.13%             56.43%                0.31                2.20                    0.01%                      
     1.003232468 CPU1      69.13%             56.23%                0.31                2.20                    0.00%                      
     1.003232468 CPU2      69.11%             56.27%                0.32                2.19                    0.00%                      

otherwise

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

      parent reply	other threads:[~2016-05-21 11:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 19:50 [PATCH 1/2] perf stat: Print topology/time headers with --metric-only Andi Kleen
2016-05-20 19:50 ` [PATCH 2/2] perf stat: Add missing aggregation headers for --metric-only CSV Andi Kleen
2016-05-21 11:19   ` Jiri Olsa
2016-05-21 11:17 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160521111703.GA5761@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.