Re: [Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

[Lukas Wunner <lukas@wunner.de>]

Hi Emil,

On Fri, May 20, 2016 at 12:41:04AM +0100, Emil Velikov wrote:
> On 19 May 2016 at 15:39, Lukas Wunner <lukas@wunner.de> wrote:
> > +bool vga_switcheroo_client_probe_defer(struct pci_dev *pdev)
> > +{
> > +       if ((pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA) {
> Not sure if we want/need this, yet at least. This changes behaviour
> which is not what refactoring patches should be doing, right ? if
> needed it ought to be a separate patch, imho.

Well, the commit message doesn't claim "no functional change", does it?

Daniel Vetter explicitly wanted the ability to use the helper in
vga_switcheroo audio clients, and those shouldn't run the apple-gmux
test. I think it makes sense to enclose it in the above-quoted if-block
*now* even though it's not needed. Once someone adds a check for an
audio client, chances are they'll forget to add this if-block.

> Furthermore on nouveau and AMD (iirc) front, some dual-gpu/optimus
> systems use PCI_CLASS_DISPLAY_3D. So if we add DISPLAY_VGA perhaps we
> should also check for DISPLAY_3D ?

Fair enough, I've changed it to match PCI_BASE_CLASS_DISPLAY
and sent it out as v5 a few minutes ago.

Thanks,

Lukas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx