From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH] dma-buf: use vma_pages(). Date: Mon, 23 May 2016 12:01:28 +0100 Message-ID: <20160523110128.GC13596@imgtec.com> References: <1463837013-17074-1-git-send-email-falakreyaz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailapp01.imgtec.com (mailapp01.imgtec.com [195.59.15.196]) by gabe.freedesktop.org (Postfix) with ESMTP id DE9AC6E592 for ; Mon, 23 May 2016 11:01:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1463837013-17074-1-git-send-email-falakreyaz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Muhammad Falak R Wani Cc: "moderated list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" , open list List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBNYXkgMjEsIDIwMTYgYXQgMDY6NTM6MzJQTSArMDUzMCwgTXVoYW1tYWQgRmFsYWsg UiBXYW5pIHdyb3RlOgo+IFJlcGxhY2UgZXhwbGljaXQgY29tcHV0YXRpb24gb2Ygdm1hIHBhZ2Ug Y291bnQgYnkgYSBjYWxsIHRvCj4gdm1hX3BhZ2VzKCkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNdWhh bW1hZCBGYWxhayBSIFdhbmkgPGZhbGFrcmV5YXpAZ21haWwuY29tPgo+IC0tLQoKR29vZCBjaGFu Z2UsIGJ1dCB0aGlzIGZ1bmN0aW9uIGlzIGRlZmluZWQgaW4gbW0uaApQbGVhc2UgYWRkOgoKICAg ICNpbmNsdWRlIDxsaW51eC9tbS5oPgoKV2l0aCB0aGF0IGZpeGVkOgpSZXZpZXdlZC1ieTogRXJp YyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0cm9tQGltZ3RlYy5jb20+Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailapp01.imgtec.com ([195.59.15.196]:61535 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193AbcEWLBb (ORCPT ); Mon, 23 May 2016 07:01:31 -0400 Date: Mon, 23 May 2016 12:01:28 +0100 From: Eric Engestrom To: Muhammad Falak R Wani CC: Sumit Semwal , "moderated list:DMA BUFFER SHARING FRAMEWORK" , open list , "open list:DMA BUFFER SHARING FRAMEWORK" , "open list:DMA BUFFER SHARING FRAMEWORK" Subject: Re: [PATCH] dma-buf: use vma_pages(). Message-ID: <20160523110128.GC13596@imgtec.com> References: <1463837013-17074-1-git-send-email-falakreyaz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1463837013-17074-1-git-send-email-falakreyaz@gmail.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Sat, May 21, 2016 at 06:53:32PM +0530, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages() > > Signed-off-by: Muhammad Falak R Wani > --- Good change, but this function is defined in mm.h Please add: #include With that fixed: Reviewed-by: Eric Engestrom