From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbcEWMIG (ORCPT ); Mon, 23 May 2016 08:08:06 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37561 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753751AbcEWMIF (ORCPT ); Mon, 23 May 2016 08:08:05 -0400 Date: Mon, 23 May 2016 13:08:01 +0100 From: Matt Fleming To: Linus Torvalds Cc: Ingo Molnar , Alex Thorlton , Linux Kernel Mailing List , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Peter Zijlstra , Borislav Petkov , Josh Poimboeuf Subject: Re: [GIT PULL] EFI fix Message-ID: <20160523120801.GB2984@codeblueprint.co.uk> References: <20160516144648.GA22999@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 May, at 01:05:45PM, Linus Torvalds wrote: > > I think the right fix is to just get rid of that silly conditional > frame pointer thing, and always use frame pointers in this stub > function. And then we don't need that (odd) load to get the old stack > pointer into %rax - we can just use the frame pointer. > > Something like the attached completely untested patch. Linus, are you going to apply your patch directly or would you prefer someone to send a pull request which also includes Josh's patch for arch/x86/entry/thunk_64.S?