From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] virtio: check mbuf is direct when using any layout Date: Mon, 23 May 2016 21:52:53 +0800 Message-ID: <20160523135253.GN5641@yliu-dev.sh.intel.com> References: <1462810775-7538-1-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, huawei.xie@intel.com, stephen@networkplumber.org To: Olivier Matz Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7398E5961 for ; Mon, 23 May 2016 15:51:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1462810775-7538-1-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 09, 2016 at 06:19:35PM +0200, Olivier Matz wrote: > The commit dd856dfcb9e74 introduced an optimization that prepends virtio > header to mbuf data. It can be used when the tx mbuf is writeable, so we > need to check that the mbuf is direct (i.e. it embeds its own data). > > Fixes: dd856dfcb9e74 "virtio: use any layout on Tx" Missing "()" here. Fixed and applied to dpdk-next-virtio. Thanks. --yliu