From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org
Subject: Re: Missing INET6_PROTO_FINAL in l2tp_ip6_protocol?
Date: Mon, 23 May 2016 14:25:21 +0300 [thread overview]
Message-ID: <20160523142521.6d0d018c@pixies> (raw)
In-Reply-To: <da054ee9-66bf-5038-b78b-18ce1c362014@stressinduktion.org>
Hi,
On Mon, 23 May 2016 13:05:50 +0200, hannes@stressinduktion.org wrote:
> > However, one more thing WRT to INET6_PROTO_FINAL not being set - we're
> > also missing the multicast filtering of 'ip6_input_finish':
> >
> > if (ipv6_addr_is_multicast(&hdr->daddr) &&
> > !ipv6_chk_mcast_addr(skb->dev, &hdr->daddr,
> > &hdr->saddr) &&
> > !ipv6_is_mld(skb, nexthdr, skb_network_header_len(skb)))
> > goto discard;
> >
> > I assume no reason to allow multicast daddr which aren't in the mc_list
> > (or saddr excluded) to pass up into 'l2tp_ip6_recv'?
> >
>
> Good point, seems we would benefit of the addition of the PROTO_FINAL
> flag. Could you test and send a patch?
Will do.
Regards,
Shmulik
prev parent reply other threads:[~2016-05-23 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 12:50 Missing INET6_PROTO_FINAL in l2tp_ip6_protocol? Shmulik Ladkani
2016-05-21 15:55 ` Hannes Frederic Sowa
2016-05-21 20:02 ` Shmulik Ladkani
2016-05-23 11:05 ` Hannes Frederic Sowa
2016-05-23 11:25 ` Shmulik Ladkani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523142521.6d0d018c@pixies \
--to=shmulik.ladkani@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.