From: Joey Hess <id@joeyh.name>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: GIT_INDEX_FILE relative path breaks in subdir
Date: Mon, 23 May 2016 13:29:51 -0400 [thread overview]
Message-ID: <20160523172951.GA1184@kitenet.net> (raw)
In-Reply-To: <xmqqwpmkafmb.fsf@gitster.mtv.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 973 bytes --]
Junio C Hamano wrote:
> Joey Hess <id@joeyh.name> writes:
>
> > This seems to make it basically impossible for any program that wants to
> > use GIT_INDEX_FILE to use anything other than an absolute path;
> > there are too many configurations to keep straight that could change how
> > git interprets what should be a simple relative path to a file.
>
> Thanks for digging. Perhaps this needs to be documented (not "in
> this case it is take as relative to that, in this other case, ...",
> but "you cannot rely on relative being relative to something you
> think").
Documenting it that way feels like ¯\_(ツ)_/¯
I feel it should be made consistently relative to top of work tree.
Seems fairly unlikely that any scripts driving git rely on it
being relative to the pwd when GIT_WORK_TREE etc is set.
(I'd prefer relative to pwd because that is much more sane IMHO, but
making that change is more likely to break something.)
--
see shy jo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2016-05-23 17:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 17:18 GIT_INDEX_FILE relative path breaks in subdir Joey Hess
2016-05-17 17:34 ` Junio C Hamano
2016-05-17 18:26 ` Joey Hess
2016-05-22 19:04 ` Joey Hess
2016-05-23 16:44 ` Junio C Hamano
2016-05-23 17:29 ` Joey Hess [this message]
2016-05-23 18:30 ` Junio C Hamano
2016-05-23 18:52 ` Joey Hess
2016-05-23 19:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523172951.GA1184@kitenet.net \
--to=id@joeyh.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.