From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Marco Trevisan <mail@3v1n0.net>,
platform-driver-x86@vger.kernel.org,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>
Subject: Re: [PATCH] thinkpad_acpi: save kbdlight state on suspend and restore it on resume
Date: Tue, 24 May 2016 00:04:09 +0200 [thread overview]
Message-ID: <201605240004.09829@pali> (raw)
In-Reply-To: <20160523215752.GC2735@f23x64.localdomain>
[-- Attachment #1: Type: Text/Plain, Size: 972 bytes --]
On Monday 23 May 2016 23:57:52 Darren Hart wrote:
> On Thu, May 19, 2016 at 03:23:02AM +0200, Marco Trevisan wrote:
> > From: Marco Trevisan (Treviño) <mail@3v1n0.net>
> >
> > Override default LED class suspend/resume handles, by keeping track
> > of the brightness level before suspending so that it can be
> > automatically restored on resume by calling default resume
> > handler.
> >
> > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
>
> The patch requires a Signed-off-by. I presume that should be from
> Marco?
>
> Henrique, is this Acked-by from you accurate? I need to see
> maintainers respond on list as they would likely object to me just
> taking other people's word for it in other scenarios ;-)
Darren, I'm not sure if this is really correct approach in current
patch... Anyway as Marco wrote, there is ACPI event when keyboard
backlight change and maybe we should handle it...
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-05-23 22:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 1:23 [PATCH] thinkpad_acpi: save kbdlight state on suspend and restore it on resume Marco Trevisan
2016-05-19 7:52 ` Pali Rohár
2016-05-20 3:03 ` Marco Trevisan (Treviño)
2016-05-23 22:09 ` Darren Hart
2016-05-23 21:57 ` Darren Hart
2016-05-23 22:04 ` Pali Rohár [this message]
2016-05-23 22:10 ` Marco Trevisan (Treviño)
2016-05-23 22:21 ` Darren Hart
2016-05-23 22:08 ` Marco Trevisan (Treviño)
2016-05-23 22:20 ` Darren Hart
2016-05-24 15:27 ` Henrique de Moraes Holschuh
2016-05-23 22:39 ` [PATCH v2] " Marco Trevisan
2016-05-24 15:49 ` Darren Hart
-- strict thread matches above, loose matches on Subject: below --
2016-05-31 17:02 [PATCH] " Marco Trevisan
2016-06-18 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201605240004.09829@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=ibm-acpi@hmh.eng.br \
--cc=mail@3v1n0.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.