From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Gabriele Mazzotta <gabriele.mzt@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"D. Jared Dominguez" <Jared_Dominguez@dell.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Alex Hung <alex.hung@canonical.com>,
Andrei Borzenkov <arvidjaar@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended
Date: Tue, 24 May 2016 00:22:28 +0200 [thread overview]
Message-ID: <201605240022.28140@pali> (raw)
In-Reply-To: <20160523221715.GE2735@f23x64.localdomain>
[-- Attachment #1: Type: Text/Plain, Size: 1039 bytes --]
On Tuesday 24 May 2016 00:17:15 Darren Hart wrote:
> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote:
> > On Monday 23 May 2016 23:26:55 Darren Hart wrote:
> > > I've queued this. Thanks for your patience.
> >
> > Ok, In that case I would update comments in patch to try it more
> > clear what code is doing.
>
> I thought I had your approval on this one Pali. Apologies if that was
> not the case. Did I miss a change request from you?
>
> If so, please point me at it, and I'll dequeue this one and wait for
> an updated one.
I just wanted to review that code from somebody else and decide if
accept it or not. Because I was not sure if it is OK...
But there was no objection, so patch is OK.
And I pointed that patch could have better comments to describe what it
is doing as at first time I was confused.
So I believe that you can update patch in your queue with new version
which just change comments in source code (without functional changes).
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-05-23 22:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 23:49 [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended Gabriele Mazzotta
2016-03-14 7:55 ` Alex Hung
2016-03-14 11:34 ` Gabriele Mazzotta
2016-03-14 11:45 ` Pali Rohár
2016-03-14 12:15 ` Andrei Borzenkov
2016-03-18 15:57 ` Andrei Borzenkov
2016-04-18 12:31 ` Pali Rohár
2016-03-18 22:44 ` [PATCH v3] " Gabriele Mazzotta
2016-03-21 12:17 ` Pali Rohár
2016-03-21 15:13 ` Gabriele Mazzotta
2016-03-24 9:39 ` Pali Rohár
2016-03-24 11:24 ` Gabriele Mazzotta
2016-03-28 17:33 ` Darren Hart
2016-03-28 17:33 ` Darren Hart
2016-03-28 17:58 ` Gabriele Mazzotta
2016-03-28 18:56 ` Darren Hart
2016-03-28 19:41 ` Gabriele Mazzotta
2016-03-29 5:24 ` Darren Hart
2016-03-29 11:13 ` Gabriele Mazzotta
2016-03-29 13:11 ` Rafael J. Wysocki
2016-04-18 12:35 ` Pali Rohár
2016-04-25 20:06 ` Gabriele Mazzotta
2016-05-19 13:30 ` Pali Rohár
2016-05-19 20:18 ` Darren Hart
2016-05-23 21:26 ` Darren Hart
2016-05-23 22:06 ` Pali Rohár
2016-05-23 22:17 ` Darren Hart
2016-05-23 22:22 ` Pali Rohár [this message]
2016-05-23 23:03 ` Gabriele Mazzotta
2016-05-24 3:48 ` Andrei Borzenkov
2016-05-24 7:09 ` Pali Rohár
2016-05-24 19:57 ` Darren Hart
2016-05-24 20:53 ` [PATCH v4] " Gabriele Mazzotta
2016-05-25 20:28 ` Darren Hart
2016-05-25 20:36 ` Pali Rohár
2016-05-25 20:47 ` Gabriele Mazzotta
2016-05-25 21:20 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201605240022.28140@pali \
--to=pali.rohar@gmail.com \
--cc=Jared_Dominguez@dell.com \
--cc=alex.hung@canonical.com \
--cc=arvidjaar@gmail.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.