From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2 5/7] eal/linux: mmap ioports on ppc64
Date: Tue, 24 May 2016 13:15:52 +0800
Message-ID: <20160524051552.GQ5641@yliu-dev.sh.intel.com>
References: <1463143859-3105-1-git-send-email-olivier.matz@6wind.com>
 <1463479192-2488-1-git-send-email-olivier.matz@6wind.com>
 <1463479192-2488-6-git-send-email-olivier.matz@6wind.com>
 <CALwxeUsY7Khn27RhKpDzdMV4VC9OcidHA2hTxHXeX3yuNWiCNQ@mail.gmail.com>
 <20160523130749.GJ5641@yliu-dev.sh.intel.com>
 <5743086A.2020103@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Chao Zhu <chaozhu@linux.vnet.ibm.com>,
 "Xie, Huawei" <huawei.xie@intel.com>,
 Panu Matilainen <pmatilai@redhat.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 458FE5A51
 for <dev@dpdk.org>; Tue, 24 May 2016 07:14:26 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <5743086A.2020103@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, May 23, 2016 at 03:40:58PM +0200, Olivier Matz wrote:
> For reference, here is the report of the ABI checker for EAL:
>=20
> [=E2=88=92] struct rte_pci_ioport (2)
>=20
>  1 Field len has been added to this type.
>    1) This field will not be initialized by old clients.
>    2) Size of the inclusive type has been changed.
>       NOTE: this field should be accessed only from the new library
>       functions, otherwise it may result in crash or incorrect behavior
>       of applications.
>  2 Size of this type has been changed from 16 bytes to 24 bytes. =09
>    The fields or parameters of such data type may be incorrectly
>    initialized or accessed by old client applications.
>=20
> [=E2=88=92] affected symbols (4)
>  rte_eal_pci_ioport_map ( struct rte_pci_device* dev, int bar,
>     struct rte_pci_ioport* p ) @@ DPDK_16.04
>  3rd parameter 'p' (pointer) has base type 'struct rte_pci_ioport'.
>  rte_eal_pci_ioport_read ( struct rte_pci_ioport* p, void* data,
>     size_t len, off_t offset ) @@ DPDK_16.04
>  1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'.
>  rte_eal_pci_ioport_unmap ( struct rte_pci_ioport* p ) @@ DPDK_16.04
>  1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'.
>  rte_eal_pci_ioport_write ( struct rte_pci_ioport* p, void const* data,
>     size_t len, off_t offset ) @@ DPDK_16.04
>  1st parameter 'p' (pointer) has base type 'struct rte_pci_ioport'.
>=20
>=20
> My understanding of the comment for this structure is that it's
> internal to EAL:

I'm not quite sure that is enough. Cc'ed Panu, the guru on ABI stuff,
hopefully he could shed some light on it.

> /**
>  * A structure used to access io resources for a pci device.
>  * rte_pci_ioport is arch, os, driver specific, and should not be used
> outside
>  * of pci ioport api.
>  */
> struct rte_pci_ioport {
>  ...
> }
>=20
> So I'd say it's ok to have it integrated for 16.07.

I'll let Thomas to decide it :)

	--yliu