From: Antonio Quartulli <a@unstable.cc>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Remove unused primary_if variable
Date: Tue, 24 May 2016 18:00:18 +0800 [thread overview]
Message-ID: <20160524100018.GB21783@prodigo.lan> (raw)
In-Reply-To: <1464042677-7787-1-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Tue, May 24, 2016 at 12:31:17AM +0200, Linus Lüssing wrote:
> Fixes: 29b9256e6631 ("batman-adv: consider outgoing interface in OGM sending")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>
> Note sure whether the "forw_packet->if_incoming != primary_if" check vanished
> on purpose or by accident in the mentioned commit. Or whether it got
> substituted by some other check. Therefore sending the patch as RFC.
I think Simon can better comment on this, but my understanding is that such
check has been moved to batadv_iv_ogm_schedule(), thus primary_if is useless in
this function.
Simon, comments ?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-24 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 22:31 [B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Remove unused primary_if variable Linus Lüssing
2016-05-24 10:00 ` Antonio Quartulli [this message]
2016-05-24 12:49 ` Simon Wunderlich
2016-05-24 12:59 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524100018.GB21783@prodigo.lan \
--to=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.