All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ppoll01: rewrite in new API
Date: Tue, 24 May 2016 14:54:47 +0200	[thread overview]
Message-ID: <20160524125446.GF10029@rei.lan> (raw)
In-Reply-To: <72553830.252358.1464078913365.JavaMail.zimbra@redhat.com>

Hi!
> > +static void cleanup(void)
> > +{
> > +	SAFE_CLOSE(fd1);
> > +	SAFE_UNLINK("testfile1");
> 
> ^^ These shouldn't be safe macros. I noticed it too late.

And the close(fd1) should be done only if it was opened.

But otherwise the test looks much better after this patch.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-05-24 12:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  8:14 [LTP] [PATCH] ppoll01: rewrite in new API Jan Stancek
2016-05-24  8:35 ` Jan Stancek
2016-05-24 12:54   ` Cyril Hrubis [this message]
2016-05-24 12:53 ` Cyril Hrubis
2016-05-24 13:51 ` [LTP] [PATCH v2] " Jan Stancek
2016-05-24 14:57   ` Cyril Hrubis
2016-05-25  7:44     ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524125446.GF10029@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.