From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] NVMe: Sync reset and scan work
Date: Tue, 24 May 2016 11:02:55 -0400 [thread overview]
Message-ID: <20160524150255.GH17208@localhost.localdomain> (raw)
In-Reply-To: <1464101341-9986-1-git-send-email-keith.busch@intel.com>
On Tue, May 24, 2016@08:49:01AM -0600, Keith Busch wrote:
> spin_lock_irq(&ctrl->lock);
> switch (new_state) {
> + case NVME_CTRL_SCHED_RESET:
> + switch (old_state) {
> + case NVME_CTRL_LIVE:
> + changed = true;
> + /* FALLTHRU */
> + default:
> + break;
> + }
Uh, the new state needs to be added as changeable from the old state
going to NVME_CTRL_RESETTING. It's important to test the same code as the
emailed patch, and that would have been obvious nothing was happening...
prev parent reply other threads:[~2016-05-24 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:49 [PATCH] NVMe: Sync reset and scan work Keith Busch
2016-05-24 15:02 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524150255.GH17208@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.