From: Fam Zheng <famz@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Drew Jones <drjones@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode
Date: Wed, 25 May 2016 09:29:03 +0800 [thread overview]
Message-ID: <20160525012903.GA23910@ad.usersys.redhat.com> (raw)
In-Reply-To: <dc530331-4abe-1161-a559-73ce6e10b532@redhat.com>
On Tue, 05/24 19:47, Laszlo Ersek wrote:
> Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode ==
> b->romd_mode).
>
> In effect, the patch seems to allow merging and equality between FlatRange
> objects when they only differ in romd_mode, and that's wrong.
>
> Given that the cover letter for this series says "memory: Dead code
> removals", I'm requesting that this patch be simply reverted.
Yes, it is a mistake, let's revert it. Thanks a lot for the analysis!
Fam
next prev parent reply other threads:[~2016-05-25 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 10:10 [Qemu-devel] [PATCH 0/2] memory: Dead code removals Fam Zheng
2016-03-25 10:10 ` [Qemu-devel] [PATCH 1/2] memory: Remove code for mr->may_overlap Fam Zheng
2016-03-29 16:14 ` Peter Maydell
2016-03-25 10:10 ` [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode Fam Zheng
2016-05-24 17:47 ` Laszlo Ersek
2016-05-24 19:25 ` Paolo Bonzini
2016-05-25 1:29 ` Fam Zheng [this message]
2016-03-25 11:19 ` [Qemu-devel] [PATCH 0/2] memory: Dead code removals Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525012903.GA23910@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.