All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] doc: Complete the documentation of statements
Date: Wed, 25 May 2016 12:01:38 +0200	[thread overview]
Message-ID: <20160525100138.GA11028@salvia> (raw)
In-Reply-To: <20160512112714.GA10290@shivani>

On Thu, May 12, 2016 at 04:57:14PM +0530, Shivani Bhardwaj wrote:
> Add documentation corresponding to LOG STATEMENT, REJECT STATEMENT,
> COUNTER STATEMENT, META STATEMENT, LIMIT STATEMENT, NAT STATEMENT,
> QUEUE STATEMENT.

We're almost there. Look, this syntax the manpage shows after your
update is not correct:

   LIMIT STATEMENT
       limit {rate | burst}

This should look like:

        limit rate [over] _rate_ [units] [burst _burst_ ]

Have a look at 'limit_stmt' in src/parser_bison.y for the production
in the grammar that we have. This should show what is there.

Would you give this another spin?

Thanks.

      reply	other threads:[~2016-05-25 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 11:27 [PATCH v3] doc: Complete the documentation of statements Shivani Bhardwaj
2016-05-25 10:01 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160525100138.GA11028@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.