From: Wei Liu <wei.liu2@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Julien Grall <julien.grall@arm.com>,
sstabellini@kernel.org, wei.liu2@citrix.com,
Chenxia Zhao <chenxiao.zhao@gmail.com>,
xen-devel@lists.xen.org
Subject: Re: [for-4.7] xen/arm: Don't call setup_virtual_regions multiple time
Date: Wed, 25 May 2016 14:44:52 +0100 [thread overview]
Message-ID: <20160525134452.GN22076@citrix.com> (raw)
In-Reply-To: <20160525133709.GB13695@char.us.oracle.com>
On Wed, May 25, 2016 at 09:37:09AM -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, May 25, 2016 at 02:14:06PM +0100, Julien Grall wrote:
> > The commit 2aa925be84293b44ad587ed117184ace61b41dd6 "arm/x86: Use struct
> > virtual_region to do bug, symbol, and (x86) exception tables lookup."
> > has introduced virtual_region. The call to initialize those regions is
> > made in init_traps which is called during each CPU bring up.
> >
> > This will result to register multiple time the same region and Xen crash
> > when an address is looked up.
>
> AAh, and that would explain why I didn't see it when I ran it under
> the emulator - I couldn't boot it with more than one CPU (the TIMER bug)!
>
> >
> > This can be fixed by moving the call to setup_virtual_region directly in
> > start_xen.
> >
> > Signed-off-by: Julien Grall <julien.grall@arm.com>
> > Reported-by: Chenxia Zhao <chenxiao.zhao@gmail.com>
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Pushed. Thanks everyone.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-25 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:14 [for-4.7] xen/arm: Don't call setup_virtual_regions multiple time Julien Grall
2016-05-25 13:28 ` Wei Liu
2016-05-25 13:37 ` Konrad Rzeszutek Wilk
2016-05-25 13:44 ` Wei Liu [this message]
2016-05-25 13:37 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525134452.GN22076@citrix.com \
--to=wei.liu2@citrix.com \
--cc=chenxiao.zhao@gmail.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.