From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:58642 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753465AbcEZNPT (ORCPT ); Thu, 26 May 2016 09:15:19 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E06C97F096 for ; Thu, 26 May 2016 13:15:17 +0000 (UTC) Received: from redhat.com (vpn-53-40.rdu2.redhat.com [10.10.53.40]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4QDFE3w000482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 26 May 2016 09:15:16 -0400 Date: Thu, 26 May 2016 15:15:13 +0200 From: Carlos Maiolino To: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fuse: Document that dentry is unused in getxattr Message-ID: <20160526131513.GC734@redhat.com> References: <1464175827-5546-1-git-send-email-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464175827-5546-1-git-send-email-agruenba@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 25, 2016 at 01:30:27PM +0200, Andreas Gruenbacher wrote: > For consistency with the other filesystems, rename the dentry argument > to "unused" here. > Make sense, you can add: Reviewed-by: Carlos Maiolino > Signed-off-by: Andreas Gruenbacher > --- > fs/fuse/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c > index b941905..5760e27 100644 > --- a/fs/fuse/dir.c > +++ b/fs/fuse/dir.c > @@ -1755,7 +1755,7 @@ static int fuse_setxattr(struct dentry *entry, const char *name, > return err; > } > > -static ssize_t fuse_getxattr(struct dentry *entry, struct inode *inode, > +static ssize_t fuse_getxattr(struct dentry *unused, struct inode *inode, > const char *name, void *value, size_t size) > { > struct fuse_conn *fc = get_fuse_conn(inode); > -- > 2.5.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos