From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.25.30.65 with SMTP id e62csp545027lfe; Thu, 26 May 2016 08:15:58 -0700 (PDT) X-Received: by 10.200.54.227 with SMTP id b32mr9390947qtc.15.1464275758331; Thu, 26 May 2016 08:15:58 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v63si13314994qkv.212.2016.05.26.08.15.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 26 May 2016 08:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Received: from localhost ([::1]:38909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5x0v-0000Ea-Ml for alex.bennee@linaro.org; Thu, 26 May 2016 11:15:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5wzL-0007XG-31 for qemu-devel@nongnu.org; Thu, 26 May 2016 11:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5wzI-0002Oa-Rf for qemu-devel@nongnu.org; Thu, 26 May 2016 11:14:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5wzF-0002MU-4v; Thu, 26 May 2016 11:14:13 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C8553750F8; Thu, 26 May 2016 15:14:12 +0000 (UTC) Received: from localhost (ovpn-204-21.brq.redhat.com [10.40.204.21]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4QFEBPY023986; Thu, 26 May 2016 11:14:12 -0400 Date: Thu, 26 May 2016 16:14:10 +0100 From: "Richard W.M. Jones" To: Peter Maydell Message-ID: <20160526151410.GH1683@redhat.com> References: <20160526144629.GH28935@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 26 May 2016 15:14:12 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , Cole Robinson Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: 7CxTQoEHZFoR On Thu, May 26, 2016 at 03:53:54PM +0100, Peter Maydell wrote: > On 26 May 2016 at 15:46, Richard W.M. Jones wrote: > > The problem with this is if I'm using TCG fallback mode, how > > can I specify the right gic-version? ie: > > > > -M virt,gic-version=host,accel=kvm:tcg > > > > Only qemu knows if KVM is going to be enabled. > > > > The same problem happens with '-cpu host' BTW. I really want a "make > > it work" option, as I've said on several previous occasions on this > > list eg: > > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04173.html > > I agree that we really need to do better here (thinking about > the problem is on my todo list but generally other more pressing > issues intervene). I'd welcome suggestions for semantics which > (a) do what you want (b) are reasonably in line with what we do > on other host architectures (c) don't break existing command lines. > (I think those are the main requirements.) > > In the meantime I think this patch is correct for what we > are currently trying to implement. Agreed this patch is an improvement on segfaulting which is what qemu does at the moment :-( Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5wzL-0007XG-31 for qemu-devel@nongnu.org; Thu, 26 May 2016 11:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5wzI-0002Oa-Rf for qemu-devel@nongnu.org; Thu, 26 May 2016 11:14:18 -0400 Date: Thu, 26 May 2016 16:14:10 +0100 From: "Richard W.M. Jones" Message-ID: <20160526151410.GH1683@redhat.com> References: <20160526144629.GH28935@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Reject gic-version=host for non-KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Cole Robinson , QEMU Developers , qemu-arm On Thu, May 26, 2016 at 03:53:54PM +0100, Peter Maydell wrote: > On 26 May 2016 at 15:46, Richard W.M. Jones wrote: > > The problem with this is if I'm using TCG fallback mode, how > > can I specify the right gic-version? ie: > > > > -M virt,gic-version=host,accel=kvm:tcg > > > > Only qemu knows if KVM is going to be enabled. > > > > The same problem happens with '-cpu host' BTW. I really want a "make > > it work" option, as I've said on several previous occasions on this > > list eg: > > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04173.html > > I agree that we really need to do better here (thinking about > the problem is on my todo list but generally other more pressing > issues intervene). I'd welcome suggestions for semantics which > (a) do what you want (b) are reasonably in line with what we do > on other host architectures (c) don't break existing command lines. > (I think those are the main requirements.) > > In the meantime I think this patch is correct for what we > are currently trying to implement. Agreed this patch is an improvement on segfaulting which is what qemu does at the moment :-( Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v